piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix misc. clang warnings - mostly complaints about inconsistent use of override.

Browse Source 
Previously, MacOpenFile only overrode anything on OS X; otherwise it was
just a useless method, which is presumably why it wasn't marked override
in the first place.  Address this more sanely by wrapping it in #ifdef
__APPLE__.
This commit is contained in:
comex 2015-06-21 15:28:49 -04:00
parent d180e4469e
commit 700b850acd
4 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/DolphinWX/ControllerConfigDiag.cpp
View File

@ -43,7 +43,7 @@ wxDEFINE_EVENT(wxEVT_ADAPTER_UPDATE, wxCommandEvent);
ControllerConfigDiag::ControllerConfigDiag(wxWindow* const parent)
: wxDialog(parent, wxID_ANY, _("Dolphin Controller Configuration"))
{
m_gc_pad_type_strs = {
m_gc_pad_type_strs = {{
_("None"),
_("Standard Controller"),
_("Steering Wheel"),
@ -52,7 +52,7 @@ ControllerConfigDiag::ControllerConfigDiag(wxWindow* const parent)
_("GBA"),
_("Keyboard"),
_("AM-Baseboard")
};
}};
wxBoxSizer* const main_sizer = new wxBoxSizer(wxVERTICAL);

2
Source/Core/DolphinWX/Main.cpp
View File

@ -276,12 +276,14 @@ bool DolphinApp::OnInit()
return true;
}
#ifdef __APPLE__
void DolphinApp::MacOpenFile(const wxString &fileName)
{
FileToLoad = fileName;
LoadFile = true;
main_frame->BootGame(WxStrToStr(FileToLoad));
}
#endif
void DolphinApp::AfterInit()
{

4
Source/Core/DolphinWX/Main.h
View File

@ -23,7 +23,9 @@ private:
void OnFatalException() override;
bool Initialize(int& c, wxChar **v) override;
void InitLanguageSupport();
void MacOpenFile(const wxString &fileName);
#ifdef __APPLE__
void MacOpenFile(const wxString &fileName) override;
#endif
bool BatchMode;
bool LoadFile;

6
Source/Core/InputCommon/ControllerInterface/OSX/OSXKeyboard.h
View File

@ -57,9 +57,9 @@ public:
Keyboard(IOHIDDeviceRef device, std::string name, int index, void *window);
std::string GetName() const;
std::string GetSource() const;
int GetId() const;
std::string GetName() const override;
std::string GetSource() const override;
int GetId() const override;
private:
struct