piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-29 00:59:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

SysConf: Make use of std::string_view

Browse Source 
We can allow strings to be used with the SysConf interface in
potentially non-allocating manners.
This commit is contained in:
Lioncash
2020-12-29 18:19:08 -05:00
parent 3b2e31230f
commit 74224c94a7
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/Core/SysConf.cpp
View File

@ -227,29 +227,29 @@ void SysConf::AddEntry(Entry&& entry)
m_entries.emplace_back(std::move(entry));
}
SysConf::Entry* SysConf::GetEntry(const std::string& key)
SysConf::Entry* SysConf::GetEntry(std::string_view key)
{
const auto iterator = std::find_if(m_entries.begin(), m_entries.end(),
[&key](const auto& entry) { return entry.name == key; });
return iterator != m_entries.end() ? &*iterator : nullptr;
}
const SysConf::Entry* SysConf::GetEntry(const std::string& key) const
const SysConf::Entry* SysConf::GetEntry(std::string_view key) const
{
const auto iterator = std::find_if(m_entries.begin(), m_entries.end(),
[&key](const auto& entry) { return entry.name == key; });
return iterator != m_entries.end() ? &*iterator : nullptr;
}
SysConf::Entry* SysConf::GetOrAddEntry(const std::string& key, Entry::Type type)
SysConf::Entry* SysConf::GetOrAddEntry(std::string_view key, Entry::Type type)
{
if (Entry* entry = GetEntry(key))
return entry;
AddEntry({type, key});
AddEntry({type, std::string(key)});
return GetEntry(key);
}
void SysConf::RemoveEntry(const std::string& key)
void SysConf::RemoveEntry(std::string_view key)
{
m_entries.erase(std::remove_if(m_entries.begin(), m_entries.end(),
[&key](const auto& entry) { return entry.name == key; }),