From 74a14c7d1fdbf19ecd1fedb1fcc5f664b130c355 Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Wed, 15 Feb 2023 19:23:47 -0800 Subject: [PATCH] ControllerInterface: Fix uninitialized variables in DualShockUDPClient Strangely, this case did not trigger a C26495 warning in Visual Studio's analyzer; instead, I spotted this when using Valgrind. --- .../DualShockUDPClient/DualShockUDPClient.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp b/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp index 12279b504b..4d3fa483e3 100644 --- a/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp +++ b/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp @@ -153,10 +153,10 @@ private: const std::string m_server_address; const u16 m_server_port; - s16 m_touch_x_min; - s16 m_touch_y_min; - s16 m_touch_x_max; - s16 m_touch_y_max; + s16 m_touch_x_min = 0; + s16 m_touch_y_min = 0; + s16 m_touch_x_max = 0; + s16 m_touch_y_max = 0; const u32 m_client_uid; }; @@ -192,7 +192,7 @@ struct Server std::string m_description; std::string m_address; - u16 m_port; + u16 m_port = 0; std::array m_port_info{}; sf::UdpSocket m_socket; SteadyClock::time_point m_disconnect_time = SteadyClock::now(); @@ -213,9 +213,9 @@ private: void StartHotplugThread(); void StopHotplugThread(); - bool m_servers_enabled; + bool m_servers_enabled = false; std::vector m_servers; - u32 m_client_uid; + u32 m_client_uid = 0; SteadyClock::time_point m_next_listports_time; std::thread m_hotplug_thread; Common::Flag m_hotplug_thread_running;