Fix all uninitialized variable warnings (C26495)

Source/Core/Core/FifoPlayer/FifoAnalyzer.h

@@ -22,8 +22,8 @@ struct CPMemory
 {
   TVtxDesc vtxDesc;
   std::array<VAT, CP_NUM_VAT_REG> vtxAttr;
-  std::array<u32, CP_NUM_ARRAYS> arrayBases;
-  std::array<u32, CP_NUM_ARRAYS> arrayStrides;
+  std::array<u32, CP_NUM_ARRAYS> arrayBases{};
+  std::array<u32, CP_NUM_ARRAYS> arrayStrides{};
 };
 
 void LoadCPReg(u32 subCmd, u32 value, CPMemory& cpMem);

Source/Core/Core/FifoPlayer/FifoDataFile.cpp

@@ -120,19 +120,19 @@ bool FifoDataFile::Save(const std::string& filename)
   PadFile(m_Frames.size() * sizeof(FileFrameInfo), file);
 
   u64 bpMemOffset = file.Tell();
-  file.WriteArray(m_BPMem, BP_MEM_SIZE);
+  file.WriteArray(m_BPMem);
 
   u64 cpMemOffset = file.Tell();
-  file.WriteArray(m_CPMem, CP_MEM_SIZE);
+  file.WriteArray(m_CPMem);
 
   u64 xfMemOffset = file.Tell();
-  file.WriteArray(m_XFMem, XF_MEM_SIZE);
+  file.WriteArray(m_XFMem);
 
   u64 xfRegsOffset = file.Tell();
-  file.WriteArray(m_XFRegs, XF_REGS_SIZE);
+  file.WriteArray(m_XFRegs);
 
   u64 texMemOffset = file.Tell();
-  file.WriteArray(m_TexMem, TEX_MEM_SIZE);
+  file.WriteArray(m_TexMem);
 
   // Write header
   FileHeader header;
@@ -285,27 +285,27 @@ std::unique_ptr<FifoDataFile> FifoDataFile::Load(const std::string& filename, bo
 
   u32 size = std::min<u32>(BP_MEM_SIZE, header.bpMemSize);
   file.Seek(header.bpMemOffset, SEEK_SET);
-  file.ReadArray(dataFile->m_BPMem, size);
+  file.ReadArray(&dataFile->m_BPMem);
 
   size = std::min<u32>(CP_MEM_SIZE, header.cpMemSize);
   file.Seek(header.cpMemOffset, SEEK_SET);
-  file.ReadArray(dataFile->m_CPMem, size);
+  file.ReadArray(&dataFile->m_CPMem);
 
   size = std::min<u32>(XF_MEM_SIZE, header.xfMemSize);
   file.Seek(header.xfMemOffset, SEEK_SET);
-  file.ReadArray(dataFile->m_XFMem, size);
+  file.ReadArray(&dataFile->m_XFMem);
 
   size = std::min<u32>(XF_REGS_SIZE, header.xfRegsSize);
   file.Seek(header.xfRegsOffset, SEEK_SET);
-  file.ReadArray(dataFile->m_XFRegs, size);
+  file.ReadArray(&dataFile->m_XFRegs);
 
   // Texture memory saving was added in version 4.
-  std::memset(dataFile->m_TexMem, 0, TEX_MEM_SIZE);
+  dataFile->m_TexMem.fill(0);
   if (dataFile->m_Version >= 4)
   {
     size = std::min<u32>(TEX_MEM_SIZE, header.texMemSize);
     file.Seek(header.texMemOffset, SEEK_SET);
-    file.ReadArray(dataFile->m_TexMem, size);
+    file.ReadArray(&dataFile->m_TexMem);
   }
 
   if (!file.IsGood())

Source/Core/Core/FifoPlayer/FifoDataFile.h

@@ -3,6 +3,7 @@
 
 #pragma once
 
+#include <array>
 #include <memory>
 #include <string>
 #include <vector>
@@ -25,18 +26,18 @@ struct MemoryUpdate
     TMEM = 0x08,
   };
 
-  u32 fifoPosition;
-  u32 address;
+  u32 fifoPosition = 0;
+  u32 address = 0;
   std::vector<u8> data;
-  Type type;
+  Type type{};
 };
 
 struct FifoFrameInfo
 {
   std::vector<u8> fifoData;
 
-  u32 fifoStart;
-  u32 fifoEnd;
+  u32 fifoStart = 0;
+  u32 fifoEnd = 0;
 
   // Must be sorted by fifoPosition
   std::vector<MemoryUpdate> memoryUpdates;
@@ -63,11 +64,11 @@ public:
   bool HasBrokenEFBCopies() const;
   bool ShouldGenerateFakeVIUpdates() const;
 
-  u32* GetBPMem() { return m_BPMem; }
-  u32* GetCPMem() { return m_CPMem; }
-  u32* GetXFMem() { return m_XFMem; }
-  u32* GetXFRegs() { return m_XFRegs; }
-  u8* GetTexMem() { return m_TexMem; }
+  u32* GetBPMem() { return m_BPMem.data(); }
+  u32* GetCPMem() { return m_CPMem.data(); }
+  u32* GetXFMem() { return m_XFMem.data(); }
+  u32* GetXFRegs() { return m_XFRegs.data(); }
+  u8* GetTexMem() { return m_TexMem.data(); }
   u32 GetRamSizeReal() { return m_ram_size_real; }
   u32 GetExRamSizeReal() { return m_exram_size_real; }
 
@@ -93,13 +94,13 @@ private:
   static void ReadMemoryUpdates(u64 fileOffset, u32 numUpdates,
                                 std::vector<MemoryUpdate>& memUpdates, File::IOFile& file);
 
-  u32 m_BPMem[BP_MEM_SIZE];
-  u32 m_CPMem[CP_MEM_SIZE];
-  u32 m_XFMem[XF_MEM_SIZE];
-  u32 m_XFRegs[XF_REGS_SIZE];
-  u8 m_TexMem[TEX_MEM_SIZE];
-  u32 m_ram_size_real;
-  u32 m_exram_size_real;
+  std::array<u32, BP_MEM_SIZE> m_BPMem{};
+  std::array<u32, CP_MEM_SIZE> m_CPMem{};
+  std::array<u32, XF_MEM_SIZE> m_XFMem{};
+  std::array<u32, XF_REGS_SIZE> m_XFRegs{};
+  std::array<u8, TEX_MEM_SIZE> m_TexMem{};
+  u32 m_ram_size_real = 0;
+  u32 m_exram_size_real = 0;
 
   u32 m_Flags = 0;
   u32 m_Version = 0;