piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-26 15:49:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

DSPDisassembler: fail when buffer too large

Browse Source
This commit is contained in:
Michael Maltese
2017-06-30 01:45:33 -07:00
parent 1d0185d7d5
commit 7dab92d8b5
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/Core/DSP/DSPDisassembler.cpp
View File

@ -27,6 +27,12 @@ DSPDisassembler::DSPDisassembler(const AssemblerSettings& settings) : settings_(
bool DSPDisassembler::Disassemble(const std::vector<u16>& code, std::string& text) bool DSPDisassembler::Disassemble(const std::vector<u16>& code, std::string& text)
{ {
if (code.size() > std::numeric_limits<u16>::max())
{
text.append("; code too large for 16-bit addressing\n");
return false;
}
for (u16 pc = 0; pc < code.size();) for (u16 pc = 0; pc < code.size();)
{ {
if (!DisassembleOpcode(code.data(), &pc, text)) if (!DisassembleOpcode(code.data(), &pc, text))