piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-28 01:49:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Make parameters, arguments etc. constant

Browse Source
This commit is contained in:
Dr. Dystopia
2025-03-25 22:52:32 +01:00
parent 2e22a3cf42
commit 8192d9d2a9
1 changed files with 28 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
Source/Core/DolphinQt/FIFO/FIFOAnalyzer.cpp
View File

@ -47,7 +47,7 @@ FIFOAnalyzer::FIFOAnalyzer(FifoPlayer& fifo_player) : m_fifo_player(fifo_player)
UpdateTree(); UpdateTree();
auto& settings = Settings::GetQSettings(); const auto& settings = Settings::GetQSettings();
m_object_splitter->restoreState( m_object_splitter->restoreState(
settings.value(QStringLiteral("fifoanalyzer/objectsplitter")).toByteArray()); settings.value(QStringLiteral("fifoanalyzer/objectsplitter")).toByteArray());
@ -147,7 +147,7 @@ void FIFOAnalyzer::UpdateTree()
m_tree_widget->addTopLevelItem(recording_item); m_tree_widget->addTopLevelItem(recording_item);
auto* file = m_fifo_player.GetFile(); const auto* const file = m_fifo_player.GetFile();
const u32 frame_count = file->GetFrameCount(); const u32 frame_count = file->GetFrameCount();
@ -202,9 +202,9 @@ namespace
class DetailCallback : public OpcodeDecoder::Callback class DetailCallback : public OpcodeDecoder::Callback
{ {
public: public:
explicit DetailCallback(CPState cpmem) : m_cpmem(cpmem) {} explicit DetailCallback(const CPState& cpmem) : m_cpmem(cpmem) {}
OPCODE_CALLBACK(void OnCP(u8 command, u32 value)) OPCODE_CALLBACK(void OnCP(const u8 command, const u32 value))
{ {
// Note: No need to update m_cpmem as it already has the final value for this object // Note: No need to update m_cpmem as it already has the final value for this object
@ -217,7 +217,7 @@ public:
.arg(QString::fromStdString(name)); .arg(QString::fromStdString(name));
} }
OPCODE_CALLBACK(void OnXF(u16 address, u8 count, const u8* data)) OPCODE_CALLBACK(void OnXF(const u16 address, const u8 count, const u8* data))
{ {
const auto [name, desc] = GetXFTransferInfo(address, count, data); const auto [name, desc] = GetXFTransferInfo(address, count, data);
ASSERT(!name.empty()); ASSERT(!name.empty());
@ -236,7 +236,7 @@ public:
text += QStringLiteral(" ") + QString::fromStdString(name); text += QStringLiteral(" ") + QString::fromStdString(name);
} }
OPCODE_CALLBACK(void OnBP(u8 command, u32 value)) OPCODE_CALLBACK(void OnBP(const u8 command, const u32 value))
{ {
const auto [name, desc] = GetBPRegInfo(command, value); const auto [name, desc] = GetBPRegInfo(command, value);
ASSERT(!name.empty()); ASSERT(!name.empty());
@ -246,15 +246,17 @@ public:
.arg(value, 6, 16, QLatin1Char('0')) .arg(value, 6, 16, QLatin1Char('0'))
.arg(QString::fromStdString(name)); .arg(QString::fromStdString(name));
} }
OPCODE_CALLBACK(void OnIndexedLoad(CPArray array, u32 index, u16 address, u8 size)) OPCODE_CALLBACK(void OnIndexedLoad(const CPArray array, const u32 index, const u16 address,
const u8 size))
{ {
const auto [desc, written] = GetXFIndexedLoadInfo(array, index, address, size); const auto [desc, written] = GetXFIndexedLoadInfo(array, index, address, size);
text = QStringLiteral("LOAD INDX %1 %2") text = QStringLiteral("LOAD INDX %1 %2")
.arg(QString::fromStdString(fmt::to_string(array))) .arg(QString::fromStdString(fmt::to_string(array)))
.arg(QString::fromStdString(desc)); .arg(QString::fromStdString(desc));
} }
OPCODE_CALLBACK(void OnPrimitiveCommand(OpcodeDecoder::Primitive primitive, u8 vat, OPCODE_CALLBACK(void OnPrimitiveCommand(const OpcodeDecoder::Primitive primitive, const u8 vat,
u32 vertex_size, u16 num_vertices, const u8* vertex_data)) const u32 vertex_size, const u16 num_vertices,
const u8* vertex_data))
{ {
const auto name = fmt::to_string(primitive); const auto name = fmt::to_string(primitive);
@ -284,14 +286,14 @@ public:
#endif #endif
} }
OPCODE_CALLBACK(void OnDisplayList(u32 address, u32 size)) OPCODE_CALLBACK(void OnDisplayList(const u32 address, const u32 size))
{ {
text = QObject::tr("Call display list at %1 with size %2") text = QObject::tr("Call display list at %1 with size %2")
.arg(address, 8, 16, QLatin1Char('0')) .arg(address, 8, 16, QLatin1Char('0'))
.arg(size, 8, 16, QLatin1Char('0')); .arg(size, 8, 16, QLatin1Char('0'));
} }
OPCODE_CALLBACK(void OnNop(u32 count)) OPCODE_CALLBACK(void OnNop(const u32 count))
{ {
if (count > 1) if (count > 1)
text = QStringLiteral("NOP (%1x)").arg(count); text = QStringLiteral("NOP (%1x)").arg(count);
@ -314,7 +316,7 @@ public:
OPCODE_CALLBACK(CPState& GetCPState()) { return m_cpmem; } OPCODE_CALLBACK(CPState& GetCPState()) { return m_cpmem; }
OPCODE_CALLBACK(u32 GetVertexSize(u8 vat)) OPCODE_CALLBACK(u32 GetVertexSize(const u8 vat))
{ {
return VertexLoaderBase::GetVertexSize(GetCPState().vtx_desc, GetCPState().vtx_attr[vat]); return VertexLoaderBase::GetVertexSize(GetCPState().vtx_desc, GetCPState().vtx_attr[vat]);
} }
@ -473,7 +475,7 @@ void FIFOAnalyzer::FindNext()
const int index = m_detail_list->currentRow(); const int index = m_detail_list->currentRow();
ASSERT(index >= 0); ASSERT(index >= 0);
auto next_result = std::ranges::find_if( const auto next_result = std::ranges::find_if(
m_search_results, [index](auto& result) { return result.m_cmd > static_cast<u32>(index); }); m_search_results, [index](auto& result) { return result.m_cmd > static_cast<u32>(index); });
if (next_result != m_search_results.end()) if (next_result != m_search_results.end())
{ {
@ -486,7 +488,7 @@ void FIFOAnalyzer::FindPrevious()
const int index = m_detail_list->currentRow(); const int index = m_detail_list->currentRow();
ASSERT(index >= 0); ASSERT(index >= 0);
auto prev_result = const auto prev_result =
std::ranges::find_if(m_search_results | std::views::reverse, [index](auto& result) { std::ranges::find_if(m_search_results | std::views::reverse, [index](auto& result) {
return result.m_cmd < static_cast<u32>(index); return result.m_cmd < static_cast<u32>(index);
}); });
@ -496,7 +498,7 @@ void FIFOAnalyzer::FindPrevious()
} }
} }
void FIFOAnalyzer::ShowSearchResult(size_t index) void FIFOAnalyzer::ShowSearchResult(const size_t index)
{ {
if (m_search_results.empty()) if (m_search_results.empty())
return; return;
@ -527,7 +529,7 @@ class DescriptionCallback : public OpcodeDecoder::Callback
public: public:
explicit DescriptionCallback(const CPState& cpmem) : m_cpmem(cpmem) {} explicit DescriptionCallback(const CPState& cpmem) : m_cpmem(cpmem) {}
OPCODE_CALLBACK(void OnBP(u8 command, u32 value)) OPCODE_CALLBACK(void OnBP(const u8 command, const u32 value))
{ {
const auto [name, desc] = GetBPRegInfo(command, value); const auto [name, desc] = GetBPRegInfo(command, value);
ASSERT(!name.empty()); ASSERT(!name.empty());
@ -542,7 +544,7 @@ public:
text += QString::fromStdString(desc); text += QString::fromStdString(desc);
} }
OPCODE_CALLBACK(void OnCP(u8 command, u32 value)) OPCODE_CALLBACK(void OnCP(const u8 command, const u32 value))
{ {
// Note: No need to update m_cpmem as it already has the final value for this object // Note: No need to update m_cpmem as it already has the final value for this object
@ -559,7 +561,7 @@ public:
text += QString::fromStdString(desc); text += QString::fromStdString(desc);
} }
OPCODE_CALLBACK(void OnXF(u16 address, u8 count, const u8* data)) OPCODE_CALLBACK(void OnXF(const u16 address, const u8 count, const u8* data))
{ {
const auto [name, desc] = GetXFTransferInfo(address, count, data); const auto [name, desc] = GetXFTransferInfo(address, count, data);
ASSERT(!name.empty()); ASSERT(!name.empty());
@ -574,7 +576,8 @@ public:
text += QString::fromStdString(desc); text += QString::fromStdString(desc);
} }
OPCODE_CALLBACK(void OnIndexedLoad(CPArray array, u32 index, u16 address, u8 size)) OPCODE_CALLBACK(void OnIndexedLoad(const CPArray array, const u32 index, const u16 address,
const u8 size))
{ {
const auto [desc, written] = GetXFIndexedLoadInfo(array, index, address, size); const auto [desc, written] = GetXFIndexedLoadInfo(array, index, address, size);
@ -606,7 +609,8 @@ public:
} }
OPCODE_CALLBACK(void OnPrimitiveCommand(OpcodeDecoder::Primitive primitive, u8 vat, OPCODE_CALLBACK(void OnPrimitiveCommand(OpcodeDecoder::Primitive primitive, u8 vat,
u32 vertex_size, u16 num_vertices, const u8* vertex_data)) const u32 vertex_size, const u16 num_vertices,
const u8* vertex_data))
{ {
const auto name = fmt::format("{} VAT {}", primitive, vat); const auto name = fmt::format("{} VAT {}", primitive, vat);
@ -619,8 +623,8 @@ public:
const auto& vtx_attr = m_cpmem.vtx_attr[vat]; const auto& vtx_attr = m_cpmem.vtx_attr[vat];
u32 i = 0; u32 i = 0;
const auto process_component = [&](VertexComponentFormat cformat, ComponentFormat format, const auto process_component = [&](const VertexComponentFormat cformat, ComponentFormat format,
u32 non_indexed_count, u32 indexed_count = 1) { const u32 non_indexed_count, const u32 indexed_count = 1) {
u32 count; u32 count;
if (cformat == VertexComponentFormat::NotPresent) if (cformat == VertexComponentFormat::NotPresent)
return; return;
@ -656,7 +660,7 @@ public:
} }
text += QLatin1Char{' '}; text += QLatin1Char{' '};
}; };
const auto process_simple_component = [&](u32 size) { const auto process_simple_component = [&](const u32 size) {
for (u32 component_off = 0; component_off < size; component_off++) for (u32 component_off = 0; component_off < size; component_off++)
{ {
text += QStringLiteral("%1").arg(vertex_data[i + component_off], 2, 16, QLatin1Char('0')); text += QStringLiteral("%1").arg(vertex_data[i + component_off], 2, 16, QLatin1Char('0'));
@ -734,7 +738,7 @@ public:
OPCODE_CALLBACK(CPState& GetCPState()) { return m_cpmem; } OPCODE_CALLBACK(CPState& GetCPState()) { return m_cpmem; }
OPCODE_CALLBACK(u32 GetVertexSize(u8 vat)) OPCODE_CALLBACK(u32 GetVertexSize(const u8 vat))
{ {
return VertexLoaderBase::GetVertexSize(GetCPState().vtx_desc, GetCPState().vtx_attr[vat]); return VertexLoaderBase::GetVertexSize(GetCPState().vtx_desc, GetCPState().vtx_attr[vat]);
} }