piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-23 22:29:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

HotkeyInputConfigDialog: Move UI creation into named functions

Browse Source 
The constructor shouldn't be used as a dumping ground for all UI-related
initialization. Doing so makes it somewhat more difficult to reason about
how certain UI elements get created. It also puts unrelated identifiers in
the same scope.

This separates the UI creation out so code relevant to each component
is self-contained.
This commit is contained in:
Lioncash
2017-01-05 15:58:23 -05:00
parent e7359f247b
commit 89da37b1c6
2 changed files with 281 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
Source/Core/DolphinWX/Input/HotkeyInputConfigDiag.h
View File

@ -6,9 +6,31 @@
#include "DolphinWX/Input/InputConfigDiag.h"
class wxBoxSizer;
class wxNotebook;
class wxPanel;
class HotkeyInputConfigDialog final : public InputConfigDialog
{
public:
HotkeyInputConfigDialog(wxWindow* parent, InputConfig& config, const wxString& name,
bool using_debugger, int port_num = 0);
private:
wxBoxSizer* CreateMainSizer();
wxBoxSizer* CreateDeviceRelatedSizer();
wxBoxSizer* CreateDeviceProfileSizer();
void InitializeNotebook();
wxPanel* CreateGeneralPanel();
wxPanel* CreateTASToolsPanel();
wxPanel* CreateDebuggingPanel();
wxPanel* CreateWiiPanel();
wxPanel* CreateGraphicsPanel();
wxPanel* CreateStereoscopic3DPanel();
wxPanel* CreateSaveAndLoadStatePanel();
wxPanel* CreateOtherStateManagementPanel();
wxNotebook* m_notebook;
bool m_using_debugger;
};