piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 06:39:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

IOFile: Require trivially copyable types

Browse Source 
Require ReadArray and WriteArray to be called with a trivially copyable
type.

ReadArray and WriteArray call std::fread and std::fwrite respectively.
These functions trigger undefined behavior when the objects are not
trivially copyable, so this adds that requirement to the callers.
This commit is contained in:
Dentomologist
2025-07-14 11:51:45 -07:00
parent 633fd5df70
commit 8a28b95480
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/Common/IOFile.h
View File

@ -54,6 +54,7 @@ public:
IOFile Duplicate(const char openmode[]) const; IOFile Duplicate(const char openmode[]) const;
template <typename T> template <typename T>
requires(std::is_trivially_copyable_v<T>)
bool ReadArray(T* elements, size_t count, size_t* num_read = nullptr) bool ReadArray(T* elements, size_t count, size_t* num_read = nullptr)
{ {
size_t read_count = 0; size_t read_count = 0;
@ -67,6 +68,7 @@ public:
} }
template <typename T> template <typename T>
requires(std::is_trivially_copyable_v<T>)
bool WriteArray(const T* elements, size_t count) bool WriteArray(const T* elements, size_t count)
{ {
if (!IsOpen() || count != std::fwrite(elements, sizeof(T), count, m_file)) if (!IsOpen() || count != std::fwrite(elements, sizeof(T), count, m_file))