piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

VideoCommon: Add fallback handling for bounding box when disabled or unsupported

Browse Source 
The SDK seems to write "default" bounding box values before every draw
(1023 0 1023 0 are the only values encountered so far, which happen to
be the extents allowed by the BP registers) to reset the registers for
comparison in the pixel engine, and presumably to detect whether GX has
updated the registers with real values. Handling these writes and
returning them on read when bounding box emulation is disabled or
unsupported, even without computing real values from rendering, seems
to prevent games from corrupting memory or crashing.

This obviously does not fix any effects that rely on bounding box
emulation, but having the game not clobber its own code/data or just
outright crash is a definite improvement.
This commit is contained in:
Techjar
2021-05-31 16:31:27 -04:00
parent 2f1b639f0a
commit 8cfe49295f
5 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/VideoCommon/VideoBackendBase.cpp
View File

@ -168,10 +168,8 @@ u16 VideoBackendBase::Video_GetBoundingBox(int index)
"for this game.");
}
warn_once = false;
return 0;
}
if (!g_ActiveConfig.backend_info.bSupportsBBox)
else if (!g_ActiveConfig.backend_info.bSupportsBBox)
{
static bool warn_once = true;
if (warn_once)
@ -182,7 +180,6 @@ u16 VideoBackendBase::Video_GetBoundingBox(int index)
"freezes while running this game.");
}
warn_once = false;
return 0;
}
Fifo::SyncGPU(Fifo::SyncGPUReason::BBox);