piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

UnitTests: Use MathUtil::SaturatingCast to avoid UB

Browse Source 
[conv.fpint]/1:

> A prvalue of a floating-point type can be converted to a prvalue of
> an integer type. The conversion truncates; that is, the fractional
> part is discarded. The behavior is undefined if the truncated value
> cannot be represented in the destination type.
This commit is contained in:
Léo Lam 2021-01-28 12:49:28 +01:00
parent 48712168b8
commit 8d21fa56a1
No known key found for this signature in database
GPG Key ID: 0DF30F9081000741
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Source/UnitTests/VideoCommon/VertexLoaderTest.cpp
View File

@ -12,6 +12,7 @@
#include "Common/BitUtils.h"
#include "Common/Common.h"
#include "Common/MathUtil.h"
#include "VideoCommon/CPMemory.h"
#include "VideoCommon/DataReader.h"
#include "VideoCommon/OpcodeDecoding.h"
@ -148,7 +149,7 @@ TEST_P(VertexLoaderParamTest, PositionAll)
-0x8000,
-0x80,
-1,
-0,
-0.0,
0,
1,
123,
@ -180,16 +181,16 @@ TEST_P(VertexLoaderParamTest, PositionAll)
switch (format)
{
case ComponentFormat::UByte:
Input((u8)value);
Input(MathUtil::SaturatingCast<u8>(value));
break;
case ComponentFormat::Byte:
Input((s8)value);
Input(MathUtil::SaturatingCast<s8>(value));
break;
case ComponentFormat::UShort:
Input((u16)value);
Input(MathUtil::SaturatingCast<u16>(value));
break;
case ComponentFormat::Short:
Input((s16)value);
Input(MathUtil::SaturatingCast<s16>(value));
break;
case ComponentFormat::Float:
Input(value);
@ -206,20 +207,20 @@ TEST_P(VertexLoaderParamTest, PositionAll)
switch (format)
{
case ComponentFormat::UByte:
f = (u8)*iter++;
g = (u8)*iter++;
f = MathUtil::SaturatingCast<u8>(*iter++);
g = MathUtil::SaturatingCast<u8>(*iter++);
break;
case ComponentFormat::Byte:
f = (s8)*iter++;
g = (s8)*iter++;
f = MathUtil::SaturatingCast<s8>(*iter++);
g = MathUtil::SaturatingCast<s8>(*iter++);
break;
case ComponentFormat::UShort:
f = (u16)*iter++;
g = (u16)*iter++;
f = MathUtil::SaturatingCast<u16>(*iter++);
g = MathUtil::SaturatingCast<u16>(*iter++);
break;
case ComponentFormat::Short:
f = (s16)*iter++;
g = (s16)*iter++;
f = MathUtil::SaturatingCast<s16>(*iter++);
g = MathUtil::SaturatingCast<s16>(*iter++);
break;
case ComponentFormat::Float:
f = *iter++;