piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 22:59:47 -06:00
Code Issues Packages Projects Releases Wiki Activity

Qt: Simplify AboutDialog creation

Browse Source 
Just create the AboutDialog on the stack -- the actual object lives on
the heap anyway, since Qt uses the pimpl idiom. Removes the need for
an explicit new and a special delete on close attribute.
This commit is contained in:
Léo Lam
2017-09-14 17:01:43 +02:00
parent 730b7fc833
commit 8f2558dc89
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Source/Core/DolphinQt2/AboutDialog.cpp
View File

@ -14,7 +14,6 @@ AboutDialog::AboutDialog(QWidget* parent) : QDialog(parent)
{ {
setWindowTitle(tr("About Dolphin")); setWindowTitle(tr("About Dolphin"));
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint); setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
setAttribute(Qt::WA_DeleteOnClose);
QString text = QStringLiteral(""); QString text = QStringLiteral("");
QString small = QStringLiteral("<p style='margin-top:0px; margin-bottom:0px; font-size:9pt;'>"); QString small = QStringLiteral("<p style='margin-top:0px; margin-bottom:0px; font-size:9pt;'>");

4
Source/Core/DolphinQt2/MainWindow.cpp
View File

@ -553,8 +553,8 @@ void MainWindow::ShowAudioWindow()
void MainWindow::ShowAboutDialog() void MainWindow::ShowAboutDialog()
{ {
AboutDialog* about = new AboutDialog(this); AboutDialog about{this};
about->show(); about.exec();
} }
void MainWindow::ShowHotkeyDialog() void MainWindow::ShowHotkeyDialog()