mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-07-23 14:19:46 -06:00
Fix shader cache bugs, improving linux speed. Remove some unnecessary printfs.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@153 8ced0084-cf51-0410-be5f-012b33b47a6e
This commit is contained in:
@ -81,6 +81,7 @@ BOOL Callback_PeekMessages()
|
||||
while (XPending(GLWin.dpy) > 0) {
|
||||
XNextEvent(GLWin.dpy, &event);
|
||||
}
|
||||
return TRUE;
|
||||
#endif
|
||||
}
|
||||
|
||||
|
@ -117,7 +117,7 @@ FRAGMENTSHADER* PixelShaderMngr::GetShader()
|
||||
PSCache::iterator iter = pshaders.find(uid);
|
||||
|
||||
if (iter != pshaders.end()) {
|
||||
iter->second.frameCount=frameCount;
|
||||
iter->second.frameCount = frameCount;
|
||||
PSCacheEntry &entry = iter->second;
|
||||
if (&entry.shader != pShaderLast)
|
||||
{
|
||||
@ -131,13 +131,14 @@ FRAGMENTSHADER* PixelShaderMngr::GetShader()
|
||||
char *code = GeneratePixelShader(s_texturemask,
|
||||
Renderer::GetZBufferTarget() != 0,
|
||||
Renderer::GetRenderMode() != Renderer::RM_Normal);
|
||||
// printf("Compiling pixel shader. size = %i\n", strlen(code));
|
||||
if (!code || !CompilePixelShader(newentry.shader, code)) {
|
||||
ERROR_LOG("failed to create pixel shader\n");
|
||||
return NULL;
|
||||
}
|
||||
|
||||
//Make an entry in the table
|
||||
newentry.frameCount=frameCount;
|
||||
newentry.frameCount = frameCount;
|
||||
|
||||
pShaderLast = &newentry.shader;
|
||||
INCSTAT(stats.numPixelShadersCreated);
|
||||
@ -150,7 +151,7 @@ void PixelShaderMngr::Cleanup()
|
||||
PSCache::iterator iter = pshaders.begin();
|
||||
while(iter != pshaders.end()) {
|
||||
PSCacheEntry &entry = iter->second;
|
||||
if (entry.frameCount<frameCount-200) {
|
||||
if (entry.frameCount < frameCount - 200) {
|
||||
entry.Destroy();
|
||||
#ifdef _WIN32
|
||||
iter = pshaders.erase(iter);
|
||||
@ -170,11 +171,7 @@ bool PixelShaderMngr::CompilePixelShader(FRAGMENTSHADER& ps, const char* pstrpro
|
||||
|
||||
char stropt[64];
|
||||
sprintf(stropt, "MaxLocalParams=32,NumInstructionSlots=%d", s_nMaxPixelInstructions);
|
||||
#ifdef _WIN32
|
||||
const char* opts[] = {"-profileopts",stropt,"-O2","-q",NULL};
|
||||
#else
|
||||
const char* opts[] = {"-profileopts",stropt,"-q",NULL};
|
||||
#endif
|
||||
CGprogram tempprog = cgCreateProgram(g_cgcontext, CG_SOURCE, pstrprogram, g_cgfProf, "main", opts);
|
||||
if (!cgIsProgram(tempprog) || cgGetError() != CG_NO_ERROR) {
|
||||
ERROR_LOG("Failed to create ps %s:\n", cgGetLastListing(g_cgcontext));
|
||||
@ -202,7 +199,6 @@ bool PixelShaderMngr::CompilePixelShader(FRAGMENTSHADER& ps, const char* pstrpro
|
||||
|
||||
//ERROR_LOG(pcompiledprog);
|
||||
//ERROR_LOG(pstrprogram);
|
||||
|
||||
glGenProgramsARB( 1, &ps.glprogid );
|
||||
glBindProgramARB( GL_FRAGMENT_PROGRAM_ARB, ps.glprogid );
|
||||
glProgramStringARB( GL_FRAGMENT_PROGRAM_ARB, GL_PROGRAM_FORMAT_ASCII_ARB, (GLsizei)strlen(pcompiledprog), pcompiledprog);
|
||||
@ -215,6 +211,7 @@ bool PixelShaderMngr::CompilePixelShader(FRAGMENTSHADER& ps, const char* pstrpro
|
||||
}
|
||||
|
||||
cgDestroyProgram(tempprog);
|
||||
printf("Compiled pixel shader %i\n", ps.glprogid);
|
||||
|
||||
#ifdef _DEBUG
|
||||
ps.strprog = pstrprogram;
|
||||
|
@ -28,17 +28,21 @@ struct FRAGMENTSHADER
|
||||
{
|
||||
FRAGMENTSHADER() : glprogid(0) { }
|
||||
GLuint glprogid; // opengl program id
|
||||
|
||||
#ifdef _DEBUG
|
||||
std::string strprog;
|
||||
#endif
|
||||
};
|
||||
|
||||
class PixelShaderMngr
|
||||
{
|
||||
class PIXELSHADERUID
|
||||
{
|
||||
public:
|
||||
PIXELSHADERUID() { values = new u32[3+32+6+11]; tevstages = indstages = 0; }
|
||||
PIXELSHADERUID() {
|
||||
values = new u32[4+32+6+11];
|
||||
memset(values, 0, (4+32+6+11) * 4);
|
||||
tevstages = indstages = 0;
|
||||
}
|
||||
~PIXELSHADERUID() { delete[] values; }
|
||||
PIXELSHADERUID(const PIXELSHADERUID& r)
|
||||
{
|
||||
@ -57,7 +61,7 @@ class PixelShaderMngr
|
||||
else if( values[0] > _Right.values[0] )
|
||||
return false;
|
||||
|
||||
int N = tevstages + 3; // numTevStages*3/2+1
|
||||
int N = tevstages + indstages + 3; // numTevStages*3/2+1
|
||||
int i = 1;
|
||||
for(; i < N; ++i) {
|
||||
if( values[i] < _Right.values[i] )
|
||||
@ -66,14 +70,6 @@ class PixelShaderMngr
|
||||
return false;
|
||||
}
|
||||
|
||||
N += indstages;
|
||||
for(; i < N; ++i) {
|
||||
if( values[i] < _Right.values[i] )
|
||||
return true;
|
||||
else if( values[i] > _Right.values[i] )
|
||||
return false;
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
@ -82,19 +78,13 @@ class PixelShaderMngr
|
||||
if( values[0] != _Right.values[0] )
|
||||
return false;
|
||||
|
||||
int N = tevstages + 3; // numTevStages*3/2+1
|
||||
int N = tevstages + indstages + 3; // numTevStages*3/2+1
|
||||
int i = 1;
|
||||
for(; i < N; ++i) {
|
||||
if( values[i] != _Right.values[i] )
|
||||
return false;
|
||||
}
|
||||
|
||||
N += indstages;
|
||||
for(; i < N; ++i) {
|
||||
if( values[i] != _Right.values[i] )
|
||||
return false;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
@ -109,7 +99,9 @@ class PixelShaderMngr
|
||||
PSCacheEntry() : frameCount(0) {}
|
||||
~PSCacheEntry() {}
|
||||
void Destroy() {
|
||||
printf("Destroying ps %i\n", shader.glprogid);
|
||||
glDeleteProgramsARB(1, &shader.glprogid);
|
||||
shader.glprogid = 0;
|
||||
}
|
||||
};
|
||||
|
||||
|
@ -183,6 +183,7 @@ bool VertexShaderMngr::CompileVertexShader(VERTEXSHADER& vs, const char* pstrpro
|
||||
}
|
||||
|
||||
cgDestroyProgram(tempprog);
|
||||
printf("Compiled vertex shader %i\n", vs.glprogid);
|
||||
|
||||
#ifdef _DEBUG
|
||||
vs.strprog = pstrprogram;
|
||||
|
@ -41,14 +41,18 @@ class VertexShaderMngr
|
||||
int frameCount;
|
||||
VSCacheEntry() : frameCount(0) {}
|
||||
void Destroy() {
|
||||
SAFE_RELEASE_PROG(shader.glprogid);
|
||||
printf("Destroying vs %i\n", shader.glprogid);
|
||||
glDeleteProgramsARB(1, &shader.glprogid);
|
||||
shader.glprogid = 0;
|
||||
}
|
||||
};
|
||||
|
||||
class VERTEXSHADERUID
|
||||
{
|
||||
public:
|
||||
VERTEXSHADERUID() {}
|
||||
VERTEXSHADERUID() {
|
||||
memset(values, 0, sizeof(values));
|
||||
}
|
||||
VERTEXSHADERUID(const VERTEXSHADERUID& r) {
|
||||
for(size_t i = 0; i < sizeof(values) / sizeof(u32); ++i)
|
||||
values[i] = r.values[i];
|
||||
|
Reference in New Issue
Block a user