piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 13:27:45 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

MemoryViewWidget:: Add auto update toggle.

Browse Source 
Stop callback when tab is not visible.
Don't check for visibility inside callback thread.
This commit is contained in:
TryTwo 2024-06-24 14:37:09 -07:00
parent b9735e18be
commit 99f3d98d3e
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Source/Core/DolphinQt/Debugger/MemoryWidget.cpp
View File

@ -66,6 +66,13 @@ MemoryWidget::MemoryWidget(Core::System& system, QWidget* parent)
connect(&Settings::Instance(), &Settings::DebugModeToggled, this,
[this](bool enabled) { setHidden(!enabled || !Settings::Instance().IsMemoryVisible()); });
connect(this, &QDockWidget::visibilityChanged, this, [this](bool visible) {
// Stop auto-update if MemoryView is tabbed out.
if (visible)
RegisterAfterFrameEventCallback();
else
RemoveAfterFrameEventCallback();
});
LoadSettings();
ConnectWidgets();
@ -255,6 +262,17 @@ void MemoryWidget::CreateWidgets()
&MemoryWidget::OnSetValueFromFile);
menubar->addMenu(menu_import);
auto* auto_update_action =
menu_views->addAction(tr("Auto update memory values"), this, [this](bool checked) {
m_auto_update_enabled = checked;
if (checked)
RegisterAfterFrameEventCallback();
else
RemoveAfterFrameEventCallback();
});
auto_update_action->setCheckable(true);
auto_update_action->setChecked(true);
auto* highlight_update_action =
menu_views->addAction(tr("Highlight recently changed values"), this,
[this](bool checked) { m_memory_view->ToggleHighlights(checked); });
@ -353,7 +371,9 @@ void MemoryWidget::closeEvent(QCloseEvent*)
void MemoryWidget::showEvent(QShowEvent* event)
{
if (m_auto_update_enabled)
RegisterAfterFrameEventCallback();
Update();
}
@ -374,9 +394,6 @@ void MemoryWidget::RemoveAfterFrameEventCallback()
void MemoryWidget::AutoUpdateTable()
{
if (!isVisible())
return;
m_memory_view->UpdateOnFrameEnd();
}

2
Source/Core/DolphinQt/Debugger/MemoryWidget.h
View File

@ -115,4 +115,6 @@ private:
QRadioButton* m_bp_write_only;
QCheckBox* m_bp_log_check;
Common::EventHook m_VI_end_field_event;
bool m_auto_update_enabled = true;
};