From 9a5a705d0111ac7546bef4e06bb86d9dd66d379b Mon Sep 17 00:00:00 2001 From: Shawn Hoffman Date: Sun, 16 Aug 2020 15:08:22 -0700 Subject: [PATCH] Fix comparison to invalidated vector iterator. GetFstEntryForPath may modify the children vector, so do it before taking an iterator to the vector. --- Source/Core/Core/IOS/FS/HostBackend/FS.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/IOS/FS/HostBackend/FS.cpp b/Source/Core/Core/IOS/FS/HostBackend/FS.cpp index 8859be7474..306cbb347b 100644 --- a/Source/Core/Core/IOS/FS/HostBackend/FS.cpp +++ b/Source/Core/Core/IOS/FS/HostBackend/FS.cpp @@ -515,9 +515,9 @@ ResultCode HostFileSystem::Rename(Uid uid, Gid gid, const std::string& old_path, } // Finally, remove the child from the old parent and move it to the new parent. + FstEntry* new_entry = GetFstEntryForPath(new_path); const auto it = std::find_if(old_parent->children.begin(), old_parent->children.end(), GetNamePredicate(split_old_path.file_name)); - FstEntry* new_entry = GetFstEntryForPath(new_path); if (it != old_parent->children.end()) { *new_entry = *it;