piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-22 22:00:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

FifoPlayer: reduce XF_REGS_SIZE to what we know

Browse Source 
This avoids out-of-bounds warnings when replaying FIFO captures.

The value of XF_REGS_SIZE is written into the DFF header and we only
read the min of XF_REGS_SIZE and the header value, so this change is
backward compatible and doesn't break forward compatibility for old
Dolphin versions either.
This commit is contained in:
Tillmann Karras
2018-10-08 06:34:41 +01:00
parent feaa466edc
commit 9c7136453d
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Core/FifoPlayer/FifoDataFile.h
View File

@ -9,6 +9,7 @@
#include <vector> #include <vector>
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
#include "VideoCommon/XFMemory.h"
namespace File namespace File
{ {
@ -50,9 +51,10 @@ public:
BP_MEM_SIZE = 256, BP_MEM_SIZE = 256,
CP_MEM_SIZE = 256, CP_MEM_SIZE = 256,
XF_MEM_SIZE = 4096, XF_MEM_SIZE = 4096,
XF_REGS_SIZE = 96, XF_REGS_SIZE = 88,
TEX_MEM_SIZE = 1024 * 1024, TEX_MEM_SIZE = 1024 * 1024,
}; };
static_assert((XF_MEM_SIZE + XF_REGS_SIZE) * sizeof(u32) == sizeof(XFMemory));
FifoDataFile(); FifoDataFile();
~FifoDataFile(); ~FifoDataFile();

1
Source/Core/VideoCommon/XFMemory.h
View File

@ -288,6 +288,7 @@ struct XFMemory
u32 unk9[8]; // 0x1048 - 0x104f u32 unk9[8]; // 0x1048 - 0x104f
PostMtxInfo postMtxInfo[8]; // 0x1050 - 0x1057 PostMtxInfo postMtxInfo[8]; // 0x1050 - 0x1057
}; };
static_assert(sizeof(XFMemory) == sizeof(u32) * 0x1058);
extern XFMemory xfmem; extern XFMemory xfmem;