From 9c7704c0ac5ed3d06e4ea99ae0c86410818740c8 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Thu, 9 Jul 2020 15:42:41 +0200 Subject: [PATCH] DolphinQt: Attempt to fix ParallelProgressDialog constantly reopening I believe the value returned by value() resets when we call setValue() with the maximum (due to auto-reset). I have been unable to test this because I can't reproduce the issue, which is described at https://bugs.dolphin-emu.org/issues/12158#note-9. --- Source/Core/DolphinQt/QtUtils/ParallelProgressDialog.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt/QtUtils/ParallelProgressDialog.h b/Source/Core/DolphinQt/QtUtils/ParallelProgressDialog.h index d9405601b3..cecb426605 100644 --- a/Source/Core/DolphinQt/QtUtils/ParallelProgressDialog.h +++ b/Source/Core/DolphinQt/QtUtils/ParallelProgressDialog.h @@ -71,8 +71,12 @@ private slots: m_is_setting_value = true; - while (m_last_received_progress != m_dialog.value()) + int last_set_progress; + do + { + last_set_progress = m_last_received_progress; m_dialog.setValue(m_last_received_progress); + } while (m_last_received_progress != last_set_progress); m_is_setting_value = false; }