piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-22 05:40:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

VideoCommon: Fix color channel logic when per-pixel lighting is in use

Browse Source 
This was broken in #10012 (specifically by 06579e4d53 and c3dec34391).
This commit is contained in:
Pokechu22
2021-10-13 20:43:32 -07:00
parent 023eb0b702
commit a372a5947b
4 changed files with 44 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
Source/Core/VideoCommon/UberShaderVertex.cpp
View File

@ -215,37 +215,29 @@ ShaderCode GenVertexShader(APIType api_type, const ShaderHostConfig& host_config
if (num_texgen > 0)
GenVertexShaderTexGens(api_type, num_texgen, out);
out.Write("// The number of colors available to TEV is determined by numColorChans.\n"
"// We have to provide the fields to match the interface, so set to zero\n"
"// if it's not enabled.\n");
const char* color_prefix;
if (per_pixel_lighting)
{
out.Write("\n// Since per-pixel lighting is enabled, the vertex colors are passed through\n"
"// unmodified so we can evaluate the lighting in the pixel shader.\n");
color_prefix = "vertex_color_";
out.Write("// When per-pixel lighting is enabled, the vertex colors are passed through\n"
"// unmodified so we can evaluate the lighting in the pixel shader.\n"
"// Lighting is also still computed in the vertex shader since it can be used to\n"
"// generate texture coordinates. We generated them above, so now the colors can\n"
"// be reverted to their previous stage.\n"
"o.colors_0 = vertex_color_0;\n"
"o.colors_1 = vertex_color_1;\n"
"// Note that the numColorChans logic should be (but currently isn't)\n"
"// performed in the pixel shader.\n");
}
else
{
color_prefix = "rawcolor";
out.Write("// The number of colors available to TEV is determined by numColorChans.\n"
"// We have to provide the fields to match the interface, so set to zero\n"
"// if it's not enabled.\n"
"if (xfmem_numColorChans == 0u)\n"
" o.colors_0 = float4(0.0, 0.0, 0.0, 0.0);\n"
"if (xfmem_numColorChans <= 1u)\n"
" o.colors_1 = float4(0.0, 0.0, 0.0, 0.0);\n");
}
out.Write("if (xfmem_numColorChans == 0u) {{\n"
" if ((components & {}u) != 0u) // VB_HAS_COL0\n"
" o.colors_0 = {}0;\n"
" else\n"
" o.colors_0 = float4(1.0, 1.0, 1.0, 1.0);\n"
"}}\n",
VB_HAS_COL0, color_prefix);
out.Write("if (xfmem_numColorChans <= 1u) {{\n"
" if ((components & {}u) != 0u) // VB_HAS_COL1\n"
" o.colors_1 = {}1;\n"
" else\n"
" o.colors_1 = o.colors_0;\n"
"}}\n",
VB_HAS_COL1, color_prefix);
if (!host_config.fast_depth_calc)
{
// clipPos/w needs to be done in pixel shader, not here