From a7ba69e16a7c0a7725d35f6c5bfe66db01aaa6a9 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Fri, 30 Mar 2018 12:01:55 +0200 Subject: [PATCH] Fix loading Wii banners for games that initially were cached without banners Fixes https://bugs.dolphin-emu.org/issues/10969 --- Source/Core/UICommon/GameFile.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Source/Core/UICommon/GameFile.cpp b/Source/Core/UICommon/GameFile.cpp index e28ef3b274..c2d9624c43 100644 --- a/Source/Core/UICommon/GameFile.cpp +++ b/Source/Core/UICommon/GameFile.cpp @@ -222,9 +222,11 @@ bool GameFile::BannerChanged() if (!DiscIO::IsWii(m_platform)) return false; - m_volume_banner.buffer = - DiscIO::WiiSaveBanner(m_title_id).GetBanner(&m_volume_banner.width, &m_volume_banner.height); - if (m_volume_banner.buffer.empty()) + m_pending.volume_banner.buffer = + DiscIO::WiiSaveBanner(m_title_id) + .GetBanner(&m_pending.volume_banner.width, &m_pending.volume_banner.height); + + if (m_pending.volume_banner.buffer.empty()) return false; // We only reach here if m_volume_banner was empty, so we can always return true