piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-08-03 03:28:43 -06:00
Code Issues Packages Projects Releases Wiki Activity

DSPAnalyzer: Hide implementation details

Browse Source 
Makes accessing flags a part of the function interface instead of exposing
an internal variable.
This commit is contained in:
Lioncash
2016-12-26 20:52:09 -05:00
parent cd29d565c4
commit a8459fc189
5 changed files with 35 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
Source/Core/Core/DSP/DSPAnalyzer.cpp
View File

@ -5,6 +5,7 @@
#include "Core/DSP/DSPAnalyzer.h"
#include <array>
#include <cstddef>
#include "Common/Logging/Log.h"
@ -13,6 +14,10 @@
namespace DSPAnalyzer
{
namespace
{
constexpr size_t ISPACE = 65536;
// Holds data about all instructions in RAM.
std::array<u8, ISPACE> code_flags;
@ -21,11 +26,11 @@ std::array<u8, ISPACE> code_flags;
// as well give up its time slice immediately, after executing once.
// Max signature length is 6. A 0 in a signature is ignored.
#define NUM_IDLE_SIGS 8
#define MAX_IDLE_SIG_SIZE 6
constexpr size_t NUM_IDLE_SIGS = 8;
constexpr size_t MAX_IDLE_SIG_SIZE = 6;
// 0xFFFF means ignore.
const u16 idle_skip_sigs[NUM_IDLE_SIGS][MAX_IDLE_SIG_SIZE + 1] = {
constexpr u16 idle_skip_sigs[NUM_IDLE_SIGS][MAX_IDLE_SIG_SIZE + 1] = {
// From AX:
{0x26fc, // LRS $30, @DMBH
0x02c0, 0x8000, // ANDCF $30, #0x8000
@ -62,12 +67,12 @@ const u16 idle_skip_sigs[NUM_IDLE_SIGS][MAX_IDLE_SIG_SIZE + 1] = {
0x0295, 0xFFFF, // JZ 0x????
0, 0}};
static void Reset()
void Reset()
{
code_flags.fill(0);
}
static void AnalyzeRange(u16 start_addr, u16 end_addr)
void AnalyzeRange(u16 start_addr, u16 end_addr)
{
// First we run an extremely simplified version of a disassembler to find
// where all instructions start.
@ -146,6 +151,7 @@ static void AnalyzeRange(u16 start_addr, u16 end_addr)
}
INFO_LOG(DSPLLE, "Finished analysis.");
}
} // Anonymous namespace
void Analyze()
{
@ -154,4 +160,9 @@ void Analyze()
AnalyzeRange(0x8000, 0x9000); // IROM
}
} // namespace
u8 GetCodeFlags(u16 address)
{
return code_flags[address];
}
} // namespace DSPAnalyzer