piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-23 14:19:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

[Android] Simplify saving settings to the ini file. Since the setting names are known, there's no reason to loop through them.

Browse Source 
This will likely be simplified further very soon.
This commit is contained in:
Lioncash
2013-08-19 20:55:50 -04:00
parent 377202b9f6
commit a87b967cde
1 changed files with 5 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
Source/Android/src/org/dolphinemu/dolphinemu/GameListActivity.java
View File

@ -25,10 +25,8 @@ import java.util.List;
public final class GameListActivity extends Activity public final class GameListActivity extends Activity
implements GameListFragment.OnGameListZeroListener implements GameListFragment.OnGameListZeroListener
{ {
private int mCurFragmentNum = 0; private int mCurFragmentNum = 0;
private Fragment mCurFragment; private Fragment mCurFragment;
enum keyTypes {TYPE_STRING, TYPE_BOOL};
private ActionBarDrawerToggle mDrawerToggle; private ActionBarDrawerToggle mDrawerToggle;
private DrawerLayout mDrawerLayout; private DrawerLayout mDrawerLayout;
@ -112,44 +110,13 @@ public final class GameListActivity extends Activity
// Settings // Settings
case 2: case 2:
{ {
String Keys[] = { // Saves the settings that the user has set in the settings menu to the Dolphin ini files.
"cpuCorePref", // This is done so that changes can be reflected when the emulator is run next.
"dualCorePref",
"gpuPref",
};
String ConfigKeys[] = {
"Core-CPUCore",
"Core-CPUThread",
"Core-GFXBackend",
};
keyTypes KeysTypes[] = {
keyTypes.TYPE_STRING,
keyTypes.TYPE_BOOL,
keyTypes.TYPE_STRING,
};
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getApplicationContext()); SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
// Set our preferences here NativeLibrary.SetConfig("Dolphin.ini", "Core", "CPUCore", prefs.getString("cpuCorePref", ""));
for (int a = 0; a < Keys.length; ++a) NativeLibrary.SetConfig("Dolphin.ini", "Core", "CPUThread", prefs.getBoolean("dualCorePref", true) ? "True" : "False");
{ NativeLibrary.SetConfig("Dolphin.ini", "Core", "GFXBackend", prefs.getString("gpuPref", ""));
String ConfigValues[] = ConfigKeys[a].split("-");
String Key = ConfigValues[0];
String Value = ConfigValues[1];
switch(KeysTypes[a])
{
case TYPE_STRING:
String strPref = prefs.getString(Keys[a], "");
NativeLibrary.SetConfig("Dolphin.ini", Key, Value, strPref);
break;
case TYPE_BOOL:
boolean boolPref = prefs.getBoolean(Keys[a], true);
NativeLibrary.SetConfig("Dolphin.ini", Key, Value, boolPref ? "True" : "False");
break;
}
}
} }
break; break;