piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 07:09:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

Common/SettingsHandler: Use std::string_view where applicable

Browse Source 
Allows passed in strings to be non-allocating.
This commit is contained in:
Lioncash
2019-07-16 04:11:53 -04:00
parent 9dd8f82e78
commit af576839d8
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Source/Core/Common/SettingsHandler.cpp
View File

@ -38,27 +38,27 @@ void SettingsHandler::SetBytes(Buffer&& buffer)
Decrypt(); Decrypt();
} }
std::string SettingsHandler::GetValue(const std::string& key) const std::string SettingsHandler::GetValue(std::string_view key) const
{ {
std::string delim = std::string("\r\n"); constexpr char delim[] = "\r\n";
std::string toFind = delim + key + "="; std::string toFind = std::string(delim).append(key).append("=");
size_t found = decoded.find(toFind); size_t found = decoded.find(toFind);
if (found != decoded.npos) if (found != std::string_view::npos)
{ {
size_t delimFound = decoded.find(delim, found + toFind.length()); size_t delimFound = decoded.find(delim, found + toFind.length());
if (delimFound == decoded.npos) if (delimFound == std::string_view::npos)
delimFound = decoded.length() - 1; delimFound = decoded.length() - 1;
return decoded.substr(found + toFind.length(), delimFound - (found + toFind.length())); return decoded.substr(found + toFind.length(), delimFound - (found + toFind.length()));
} }
else else
{ {
toFind = key + "="; toFind = std::string(key).append("=");
found = decoded.find(toFind); found = decoded.find(toFind);
if (found == 0) if (found == 0)
{ {
size_t delimFound = decoded.find(delim, found + toFind.length()); size_t delimFound = decoded.find(delim, found + toFind.length());
if (delimFound == decoded.npos) if (delimFound == std::string_view::npos)
delimFound = decoded.length() - 1; delimFound = decoded.length() - 1;
return decoded.substr(found + toFind.length(), delimFound - (found + toFind.length())); return decoded.substr(found + toFind.length(), delimFound - (found + toFind.length()));
} }
@ -89,7 +89,7 @@ void SettingsHandler::Reset()
m_buffer = {}; m_buffer = {};
} }
void SettingsHandler::AddSetting(const std::string& key, const std::string& value) void SettingsHandler::AddSetting(std::string_view key, std::string_view value)
{ {
for (const char& c : key) for (const char& c : key)
{ {

5
Source/Core/Common/SettingsHandler.h
View File

@ -8,6 +8,7 @@
#include <array> #include <array>
#include <string> #include <string>
#include <string_view>
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
@ -27,11 +28,11 @@ public:
SettingsHandler(); SettingsHandler();
explicit SettingsHandler(Buffer&& buffer); explicit SettingsHandler(Buffer&& buffer);
void AddSetting(const std::string& key, const std::string& value); void AddSetting(std::string_view key, std::string_view value);
const Buffer& GetBytes() const; const Buffer& GetBytes() const;
void SetBytes(Buffer&& buffer); void SetBytes(Buffer&& buffer);
std::string GetValue(const std::string& key) const; std::string GetValue(std::string_view key) const;
void Decrypt(); void Decrypt();
void Reset(); void Reset();