piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

VideoCommon/OpcodeDecoding: Move g_bRecordFifoData into namespace

Browse Source 
Keeps the global localized with the code that it's primarily related to.

Now it's obvious from a glance what the global variable is affecting.
This commit is contained in:
Lioncash
2019-12-05 08:11:52 -05:00
parent d8063e9c54
commit b2a9c36501
6 changed files with 24 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/VideoCommon/OpcodeDecoding.cpp
View File

@ -30,8 +30,6 @@
#include "VideoCommon/VideoCommon.h"
#include "VideoCommon/XFMemory.h"
bool g_bRecordFifoData = false;
namespace OpcodeDecoder
{
static bool s_is_fifo_error_seen = false;
@ -75,6 +73,8 @@ static void InterpretDisplayListPreprocess(u32 address, u32 size)
Run<true>(DataReader(start_address, start_address + size), nullptr, true);
}
bool g_record_fifo_data = false;
void Init()
{
s_is_fifo_error_seen = false;
@ -255,7 +255,7 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
}
// Display lists get added directly into the FIFO stream
if (!is_preprocess && g_bRecordFifoData && cmd_byte != GX_CMD_CALL_DL)
if (!is_preprocess && g_record_fifo_data && cmd_byte != GX_CMD_CALL_DL)
{
const u8* const opcode_end = src.GetPointer();
FifoRecorder::GetInstance().WriteGPCommand(opcode_start, u32(opcode_end - opcode_start));