piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 14:49:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13812 from Dentomologist/memoryviewwidget_fix_updates_at_end_of_address_space

Browse Source 
MemoryViewWidget: Fix updates at end of address space
This commit is contained in:
JMC47
2025-07-19 00:42:34 -04:00
committed by GitHub
parent 4868970504 43ab79ae23
commit b2b2808d01
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp
View File

@ -473,7 +473,7 @@ void MemoryViewWidget::Update()
const int data_span = m_bytes_per_row / GetTypeSize(m_type); const int data_span = m_bytes_per_row / GetTypeSize(m_type);
m_address_range.first = row_address; m_address_range.first = row_address;
m_address_range.second = row_address + m_table->rowCount() * m_bytes_per_row - 1; m_address_range.second = row_address + m_table->rowCount() * m_bytes_per_row;
for (int i = 0; i < m_table->rowCount(); i++, row_address += m_bytes_per_row) for (int i = 0; i < m_table->rowCount(); i++, row_address += m_bytes_per_row)
{ {
@ -611,9 +611,13 @@ void MemoryViewWidget::GetValues()
// Grab memory values as QStrings // Grab memory values as QStrings
Core::CPUThreadGuard guard(m_system); Core::CPUThreadGuard guard(m_system);
for (u32 address = m_address_range.first; address <= m_address_range.second; const u32 type_size = static_cast<u32>(GetTypeSize(m_type));
address += GetTypeSize(m_type)) const auto& [range_begin, range_end] = m_address_range;
const u32 address_count = (range_end - range_begin) / type_size;
for (u32 i = 0; i < address_count; ++i)
{ {
const u32 address = range_begin + i * type_size;
m_values.insert(std::pair(address, ValueToString(guard, address, m_type))); m_values.insert(std::pair(address, ValueToString(guard, address, m_type)));
if (m_dual_view) if (m_dual_view)