piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 07:09:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

BreakPoints: Invert if statements where reasonable

Browse Source 
Puts the early-exit condition first, unindenting code that doesn't need
to be.
This commit is contained in:
Lioncash
2018-03-19 02:51:59 -04:00
parent 3137d4f75f
commit b4cd11c7c9
1 changed files with 42 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
Source/Core/Core/PowerPC/BreakPoints.cpp
View File

@ -62,18 +62,21 @@ void BreakPoints::AddFromStrings(const TBreakPointsStr& bp_strings)
void BreakPoints::Add(const TBreakPoint& bp) void BreakPoints::Add(const TBreakPoint& bp)
{ {
if (!IsAddressBreakPoint(bp.address)) if (IsAddressBreakPoint(bp.address))
{ return;
m_breakpoints.push_back(bp); m_breakpoints.push_back(bp);
if (g_jit) if (g_jit)
g_jit->GetBlockCache()->InvalidateICache(bp.address, 4, true); g_jit->GetBlockCache()->InvalidateICache(bp.address, 4, true);
} }
}
void BreakPoints::Add(u32 address, bool temp) void BreakPoints::Add(u32 address, bool temp)
{ {
if (!IsAddressBreakPoint(address)) // only add new addresses // Only add new addresses
{ if (IsAddressBreakPoint(address))
return;
TBreakPoint bp; // breakpoint settings TBreakPoint bp; // breakpoint settings
bp.is_enabled = true; bp.is_enabled = true;
bp.is_temporary = temp; bp.is_temporary = temp;
@ -84,7 +87,6 @@ void BreakPoints::Add(u32 address, bool temp)
if (g_jit) if (g_jit)
g_jit->GetBlockCache()->InvalidateICache(address, 4, true); g_jit->GetBlockCache()->InvalidateICache(address, 4, true);
} }
}
void BreakPoints::Remove(u32 address) void BreakPoints::Remove(u32 address)
{ {
@ -170,8 +172,9 @@ void MemChecks::AddFromStrings(const TMemChecksStr& mc_strings)
void MemChecks::Add(const TMemCheck& memory_check) void MemChecks::Add(const TMemCheck& memory_check)
{ {
if (GetMemCheck(memory_check.start_address) == nullptr) if (GetMemCheck(memory_check.start_address) != nullptr)
{ return;
bool had_any = HasAny(); bool had_any = HasAny();
Core::RunAsCPUThread([&] { Core::RunAsCPUThread([&] {
m_mem_checks.push_back(memory_check); m_mem_checks.push_back(memory_check);
@ -182,7 +185,6 @@ void MemChecks::Add(const TMemCheck& memory_check)
PowerPC::DBATUpdated(); PowerPC::DBATUpdated();
}); });
} }
}
void MemChecks::Remove(u32 address) void MemChecks::Remove(u32 address)
{ {
@ -284,23 +286,24 @@ void Watches::AddFromStrings(const TWatchesStr& watch_strings)
void Watches::Add(const TWatch& watch) void Watches::Add(const TWatch& watch)
{ {
if (!IsAddressWatch(watch.address)) if (IsAddressWatch(watch.address))
{ return;
m_watches.push_back(watch); m_watches.push_back(watch);
} }
}
void Watches::Add(u32 address) void Watches::Add(u32 address)
{ {
if (!IsAddressWatch(address)) // only add new addresses // Only add new addresses
{ if (IsAddressWatch(address))
return;
TWatch watch; // watch settings TWatch watch; // watch settings
watch.is_enabled = true; watch.is_enabled = true;
watch.address = address; watch.address = address;
m_watches.push_back(watch); m_watches.push_back(watch);
} }
}
void Watches::Update(int count, u32 address) void Watches::Update(int count, u32 address)
{ {