From 9dacefcbf1790564c5432de1f7dfadfc3d5c4be7 Mon Sep 17 00:00:00 2001 From: dreamsyntax Date: Sat, 19 Oct 2024 17:17:10 -0700 Subject: [PATCH 1/2] GraphicsSettings: EFBAccessEnable=false by default Makes Graphics -> Hacks -> Skip EFB Access from CPU enabled by default. Some GPU drivers stall when EFB access occurs in games where EFB is not used. Most games that require this setting set to 'true' already have this defined in their game inis. --- .../dolphinemu/features/settings/model/BooleanSetting.kt | 2 +- Source/Core/Core/Config/GraphicsSettings.cpp | 2 +- Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt index c83d1cc923..156d6ccd4c 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.kt @@ -789,7 +789,7 @@ enum class BooleanSetting( Settings.FILE_GFX, Settings.SECTION_GFX_HACKS, "EFBAccessEnable", - true + false ), GFX_HACK_EFB_DEFER_INVALIDATION( Settings.FILE_GFX, diff --git a/Source/Core/Core/Config/GraphicsSettings.cpp b/Source/Core/Core/Config/GraphicsSettings.cpp index cd916c6864..708a4ebe0d 100644 --- a/Source/Core/Core/Config/GraphicsSettings.cpp +++ b/Source/Core/Core/Config/GraphicsSettings.cpp @@ -177,7 +177,7 @@ const Info GFX_STEREO_DEPTH_PERCENTAGE{{System::GFX, "Stereoscopy", "Stereo // Graphics.Hacks -const Info GFX_HACK_EFB_ACCESS_ENABLE{{System::GFX, "Hacks", "EFBAccessEnable"}, true}; +const Info GFX_HACK_EFB_ACCESS_ENABLE{{System::GFX, "Hacks", "EFBAccessEnable"}, false}; const Info GFX_HACK_EFB_DEFER_INVALIDATION{ {System::GFX, "Hacks", "EFBAccessDeferInvalidation"}, false}; const Info GFX_HACK_EFB_ACCESS_TILE_SIZE{{System::GFX, "Hacks", "EFBAccessTileSize"}, 64}; diff --git a/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp index 135f358356..19712e38f8 100644 --- a/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp @@ -223,7 +223,7 @@ void HacksWidget::AddDescriptions() "Ignores any requests from the CPU to read from or write to the EFB. " "

Improves performance in some games, but will disable all EFB-based " "graphical effects or gameplay-related features.

If unsure, " - "leave this unchecked."); + "leave this checked."); static const char TR_IGNORE_FORMAT_CHANGE_DESCRIPTION[] = QT_TR_NOOP( "Ignores any changes to the EFB format.

Improves performance in many games " "without " From 6022cca691e7a40e4cacea07893580df617b7386 Mon Sep 17 00:00:00 2001 From: dreamsyntax Date: Wed, 23 Oct 2024 18:07:10 -0700 Subject: [PATCH 2/2] GameINI: Remove EFBAccessEnable=false overrides Removes the EFBAccessEnable=false explicit game overrides for: GT6 (Terminator 3: The Redemption) GXB (SSX3) [deleted - no other configuration] RTH (Tony Hawk's Downhill Jam) SNC (SONIC COLOURS) [deleted - no other configuration] --- Data/Sys/GameSettings/GT6.ini | 3 --- Data/Sys/GameSettings/GXB.ini | 14 -------------- Data/Sys/GameSettings/RTH.ini | 3 --- Data/Sys/GameSettings/SNC.ini | 14 -------------- 4 files changed, 34 deletions(-) delete mode 100644 Data/Sys/GameSettings/GXB.ini delete mode 100644 Data/Sys/GameSettings/SNC.ini diff --git a/Data/Sys/GameSettings/GT6.ini b/Data/Sys/GameSettings/GT6.ini index cc782ceec2..12cf82d82f 100644 --- a/Data/Sys/GameSettings/GT6.ini +++ b/Data/Sys/GameSettings/GT6.ini @@ -9,8 +9,5 @@ [ActionReplay] # Add action replay cheats here. -[Video_Settings] - [Video_Hacks] -EFBAccessEnable = False ImmediateXFBEnable = False diff --git a/Data/Sys/GameSettings/GXB.ini b/Data/Sys/GameSettings/GXB.ini deleted file mode 100644 index 277560f1f2..0000000000 --- a/Data/Sys/GameSettings/GXB.ini +++ /dev/null @@ -1,14 +0,0 @@ -# GXBE69, GXBP69 - SSX3 - -[Core] -# Values set here will override the main Dolphin settings. - -[OnFrame] -# Add memory patches to be applied every frame here. - -[ActionReplay] -# Add action replay cheats here. - -[Video_Hacks] -EFBAccessEnable = False - diff --git a/Data/Sys/GameSettings/RTH.ini b/Data/Sys/GameSettings/RTH.ini index 865b6d69bf..29189d80e4 100644 --- a/Data/Sys/GameSettings/RTH.ini +++ b/Data/Sys/GameSettings/RTH.ini @@ -16,6 +16,3 @@ $Disable blur [Video_Settings] SafeTextureCacheColorSamples = 0 - -[Video_Hacks] -EFBAccessEnable = False diff --git a/Data/Sys/GameSettings/SNC.ini b/Data/Sys/GameSettings/SNC.ini deleted file mode 100644 index 3c97848ab1..0000000000 --- a/Data/Sys/GameSettings/SNC.ini +++ /dev/null @@ -1,14 +0,0 @@ -# SNCE8P, SNCJ8P, SNCP8P - SONIC COLOURS - -[Core] -# Values set here will override the main Dolphin settings. - -[OnFrame] -# Add memory patches to be applied every frame here. - -[ActionReplay] -# Add action replay cheats here. - -[Video_Hacks] -EFBAccessEnable = False -