From bced5fac183b953d9ddd2f488c7ac3917eabee1a Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 12 Dec 2023 19:21:33 -0500 Subject: [PATCH] Common/Crypto/AES: Resolve -Wignored-attributes warnings The alias for __m128i is typically something like: typedef long long __m128i __attribute__((__vector_size__(16), __may_alias__)); and the part that ends up not getting preserved is the __may_alias__ attribute specifier. So, in order to preserve that, we can just use a wrapper struct, so the data type itself isn't being passed through the template. --- Source/Core/Common/Crypto/AES.cpp | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Source/Core/Common/Crypto/AES.cpp b/Source/Core/Common/Crypto/AES.cpp index 3fc9a80a56..272341ecca 100644 --- a/Source/Core/Common/Crypto/AES.cpp +++ b/Source/Core/Common/Crypto/AES.cpp @@ -250,7 +250,19 @@ public: } private: - std::array<__m128i, NUM_ROUND_KEYS> round_keys; + // Ensures alignment specifiers are respected. + struct XmmReg + { + __m128i data; + + XmmReg& operator=(const __m128i& m) + { + data = m; + return *this; + } + operator __m128i() const { return data; } + }; + std::array round_keys; }; #endif