piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-23 14:19:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added the ability to search on previous value in the Cheat Search.

Browse Source 
Fixed a bug where old values were being updated automatically by the display refresh.

Fixes issue 9212.
This commit is contained in:
skidau
2015-12-30 11:51:36 +11:00
parent 8cf078a1a0
commit c055b40d3b
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Source/Core/DolphinWX/Cheats/CheatSearchTab.cpp
View File

@ -86,7 +86,7 @@ CheatSearchTab::CheatSearchTab(wxWindow* const parent)
m_search_type = new wxChoice(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, filters); m_search_type = new wxChoice(this, wxID_ANY, wxDefaultPosition, wxDefaultSize, filters);
m_search_type->Select(0); m_search_type->Select(0);
wxStaticBoxSizer* const sizer_cheat_search_filter = new wxStaticBoxSizer(wxVERTICAL, this, _("Search")); wxStaticBoxSizer* const sizer_cheat_search_filter = new wxStaticBoxSizer(wxVERTICAL, this, _("Search (clear to use previous value)"));
sizer_cheat_search_filter->Add(sizer_cheat_filter_text, 0, wxALL | wxEXPAND, 5); sizer_cheat_search_filter->Add(sizer_cheat_filter_text, 0, wxALL | wxEXPAND, 5);
sizer_cheat_search_filter->Add(m_search_type, 0, wxALL, 5); sizer_cheat_search_filter->Add(m_search_type, 0, wxALL, 5);
@ -153,10 +153,14 @@ void CheatSearchTab::OnNextScanClicked(wxCommandEvent&)
} }
u32 user_x_val = 0; u32 user_x_val = 0;
if (!ParseUserEnteredValue(&user_x_val)) bool blank_user_value = m_textctrl_value_x->IsEmpty();
return; if (!blank_user_value)
{
if (!ParseUserEnteredValue(&user_x_val))
return;
}
FilterCheatSearchResults(user_x_val); FilterCheatSearchResults(user_x_val, blank_user_value);
UpdateCheatSearchResultsList(); UpdateCheatSearchResultsList();
} }
@ -232,7 +236,6 @@ void CheatSearchTab::UpdateCheatSearchResultItem(long index)
{ {
u32 address_value = 0; u32 address_value = 0;
std::memcpy(&address_value, &Memory::m_pRAM[m_search_results[index].address], m_search_type_size); std::memcpy(&address_value, &Memory::m_pRAM[m_search_results[index].address], m_search_type_size);
m_search_results[index].old_value = address_value;
u32 display_value = SwapValue(address_value); u32 display_value = SwapValue(address_value);
@ -270,7 +273,7 @@ static ComparisonMask operator & (ComparisonMask comp1, ComparisonMask comp2)
static_cast<int>(comp2)); static_cast<int>(comp2));
} }
void CheatSearchTab::FilterCheatSearchResults(u32 value) void CheatSearchTab::FilterCheatSearchResults(u32 value, bool prev)
{ {
static const std::array<ComparisonMask, 5> filters{{ static const std::array<ComparisonMask, 5> filters{{
ComparisonMask::EQUAL | ComparisonMask::GREATER_THAN | ComparisonMask::LESS_THAN, // Unknown ComparisonMask::EQUAL | ComparisonMask::GREATER_THAN | ComparisonMask::LESS_THAN, // Unknown
@ -286,6 +289,9 @@ void CheatSearchTab::FilterCheatSearchResults(u32 value)
for (CheatSearchResult& result : m_search_results) for (CheatSearchResult& result : m_search_results)
{ {
if (prev)
value = result.old_value;
// with big endian, can just use memcmp for ><= comparison // with big endian, can just use memcmp for ><= comparison
int cmp_result = std::memcmp(&Memory::m_pRAM[result.address], &value, m_search_type_size); int cmp_result = std::memcmp(&Memory::m_pRAM[result.address], &value, m_search_type_size);
ComparisonMask cmp_mask; ComparisonMask cmp_mask;

2
Source/Core/DolphinWX/Cheats/CheatSearchTab.h
View File

@ -34,7 +34,7 @@ private:
void UpdateCheatSearchResultsList(); void UpdateCheatSearchResultsList();
void UpdateCheatSearchResultItem(long index); void UpdateCheatSearchResultItem(long index);
void FilterCheatSearchResults(u32 value); void FilterCheatSearchResults(u32 value, bool prev);
void ResetListViewColumns(); void ResetListViewColumns();
bool ParseUserEnteredValue(u32* out) const; bool ParseUserEnteredValue(u32* out) const;
u32 SwapValue(u32 value) const; u32 SwapValue(u32 value) const;