From c0f499b7f7e84e490d20f3b999714f3f5b43544e Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 28 May 2019 17:47:26 -0400 Subject: [PATCH] Common/FileUtil: Use std::string_view with WriteStringToFile Allows writing out other forms of strings (e.g. C strings) without the need to allocate a std::string and discard it after use. --- Source/Core/Common/FileUtil.cpp | 2 +- Source/Core/Common/FileUtil.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Source/Core/Common/FileUtil.cpp b/Source/Core/Common/FileUtil.cpp index 826d430b62..01f4417e1d 100644 --- a/Source/Core/Common/FileUtil.cpp +++ b/Source/Core/Common/FileUtil.cpp @@ -887,7 +887,7 @@ std::string GetThemeDir(const std::string& theme_name) return GetSysDirectory() + THEMES_DIR "/" DEFAULT_THEME_DIR "/"; } -bool WriteStringToFile(const std::string& filename, const std::string& str) +bool WriteStringToFile(const std::string& filename, std::string_view str) { return File::IOFile(filename, "wb").WriteBytes(str.data(), str.size()); } diff --git a/Source/Core/Common/FileUtil.h b/Source/Core/Common/FileUtil.h index cccb28e218..57e645c285 100644 --- a/Source/Core/Common/FileUtil.h +++ b/Source/Core/Common/FileUtil.h @@ -7,6 +7,7 @@ #include #include #include +#include #include #include @@ -198,7 +199,7 @@ std::string GetBundleDirectory(); std::string GetExePath(); std::string GetExeDirectory(); -bool WriteStringToFile(const std::string& filename, const std::string& str); +bool WriteStringToFile(const std::string& filename, std::string_view str); bool ReadFileToString(const std::string& filename, std::string& str); // To deal with Windows being dumb at unicode: