ChangeGameDialog: Internally set the chosen game name

Passing in a reference to an empty string is unnecessary and
overcomplicates design.
This commit is contained in:
Lioncash
2015-08-16 01:08:51 -04:00
parent af35f38491
commit ca0b9481ea
3 changed files with 18 additions and 14 deletions

View File

@ -445,17 +445,16 @@ void NetPlayDialog::OnThread(wxThreadEvent& event)
void NetPlayDialog::OnChangeGame(wxCommandEvent&)
{
wxString game_name;
ChangeGameDialog cgd(this, m_game_list, game_name);
ChangeGameDialog cgd(this, m_game_list);
cgd.ShowModal();
if (game_name.length())
{
m_selected_game = WxStrToStr(game_name);
netplay_server->ChangeGame(m_selected_game);
m_game_btn->SetLabel(game_name.Prepend(_(" Game : ")));
}
wxString game_name = cgd.GetChosenGameName();
if (game_name.empty())
return;
m_selected_game = WxStrToStr(game_name);
netplay_server->ChangeGame(m_selected_game);
m_game_btn->SetLabel(game_name.Prepend(_(" Game : ")));
}
void NetPlayDialog::OnConfigPads(wxCommandEvent&)