piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 06:39:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

TraversalClient: Make data externally read-only members private

Browse Source 
These are only ever queried for state, not written. Therefore, prevent writing to the members
and make them private.
This commit is contained in:
Lioncash
2018-04-16 16:02:21 -04:00
parent dfd6a228a6
commit ca6a2970ea
6 changed files with 44 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Source/Core/Common/TraversalClient.cpp
View File

@ -32,8 +32,21 @@ TraversalClient::TraversalClient(ENetHost* netHost, const std::string& server, c
ReconnectToServer();
}
TraversalClient::~TraversalClient()
TraversalClient::~TraversalClient() = default;
TraversalHostId TraversalClient::GetHostID() const
{
return m_HostId;
}
TraversalClient::State TraversalClient::GetState() const
{
return m_State;
}
TraversalClient::FailureReason TraversalClient::GetFailureReason() const
{
return m_FailureReason;
}
void TraversalClient::ReconnectToServer()

14
Source/Core/Common/TraversalClient.h
View File

@ -41,6 +41,11 @@ public:
};
TraversalClient(ENetHost* netHost, const std::string& server, const u16 port);
~TraversalClient();
TraversalHostId GetHostID() const;
State GetState() const;
FailureReason GetFailureReason() const;
void Reset();
void ConnectToClient(const std::string& host);
void ReconnectToServer();
@ -49,11 +54,7 @@ public:
bool TestPacket(u8* data, size_t size, ENetAddress* from);
void HandleResends();
ENetHost* m_NetHost;
TraversalClientClient* m_Client;
TraversalHostId m_HostId;
State m_State;
FailureReason m_FailureReason;
private:
struct OutgoingTraversalPacketInfo
@ -68,6 +69,11 @@ private:
void OnFailure(FailureReason reason);
void HandlePing();
static int ENET_CALLBACK InterceptCallback(ENetHost* host, ENetEvent* event);
ENetHost* m_NetHost;
TraversalHostId m_HostId;
State m_State;
FailureReason m_FailureReason;
TraversalRequestId m_ConnectRequestId;
bool m_PendingConnect;
std::list<OutgoingTraversalPacketInfo> m_OutgoingTraversalPackets;