Merge pull request #10309 from aldelaro5/gdb-stub-fix-watchpoints

Gdb stub: fix watchpoints
This commit is contained in:
Léo Lam 2022-01-03 01:33:49 +01:00 committed by GitHub
commit cbd1c4969d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -53,11 +53,13 @@ enum class BreakpointType
{ {
ExecuteSoft = 0, ExecuteSoft = 0,
ExecuteHard, ExecuteHard,
Read,
Write, Write,
Read,
Access, Access,
}; };
constexpr u32 NUM_BREAKPOINT_TYPES = 4;
const s64 GDB_UPDATE_CYCLES = 100000; const s64 GDB_UPDATE_CYCLES = 100000;
static bool s_has_control = false; static bool s_has_control = false;
@ -858,7 +860,7 @@ static void HandleAddBreakpoint()
u32 i, addr = 0, len = 0; u32 i, addr = 0, len = 0;
type = Hex2char(s_cmd_bfr[1]); type = Hex2char(s_cmd_bfr[1]);
if (type > 4) if (type > NUM_BREAKPOINT_TYPES)
return SendReply("E01"); return SendReply("E01");
i = 3; i = 3;
@ -879,7 +881,7 @@ static void HandleRemoveBreakpoint()
u32 type, addr, len, i; u32 type, addr, len, i;
type = Hex2char(s_cmd_bfr[1]); type = Hex2char(s_cmd_bfr[1]);
if (type >= 4) if (type > NUM_BREAKPOINT_TYPES)
return SendReply("E01"); return SendReply("E01");
addr = 0; addr = 0;