piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-23 14:19:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

Pass SettingsHandler buffers by const ref instead of rvalue ref

Browse Source
This commit is contained in:
Niel Lebeck
2024-04-12 18:50:21 -07:00
parent 107379bf74
commit d2b96736e0
6 changed files with 18 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Common/SettingsHandler.cpp
View File

@ -22,9 +22,9 @@ SettingsHandler::SettingsHandler()
Reset();
}
SettingsHandler::SettingsHandler(Buffer&& buffer)
SettingsHandler::SettingsHandler(const Buffer& buffer)
{
SetBytes(std::move(buffer));
SetBytes(buffer);
}
const SettingsHandler::Buffer& SettingsHandler::GetBytes() const
@ -32,10 +32,10 @@ const SettingsHandler::Buffer& SettingsHandler::GetBytes() const
return m_buffer;
}
void SettingsHandler::SetBytes(Buffer&& buffer)
void SettingsHandler::SetBytes(const Buffer& buffer)
{
Reset();
m_buffer = std::move(buffer);
m_buffer = buffer;
Decrypt();
}

4
Source/Core/Common/SettingsHandler.h
View File

@ -25,12 +25,12 @@ public:
using Buffer = std::array<u8, SETTINGS_SIZE>;
SettingsHandler();
explicit SettingsHandler(Buffer&& buffer);
explicit SettingsHandler(const Buffer& buffer);
void AddSetting(std::string_view key, std::string_view value);
const Buffer& GetBytes() const;
void SetBytes(Buffer&& buffer);
void SetBytes(const Buffer& buffer);
std::string GetValue(std::string_view key) const;
void Decrypt();