piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-09-13 23:12:45 -06:00
Code Issues Packages Projects Releases Wiki Activity

MathUtil: Simplify SaturatingCast implementation with std::cmp_less/cmp_greater and fix a floating point edge case.

Browse Source 
Thanks to Dentomologist for catching the edge case.
This commit is contained in:
Jordan Woyak
2025-08-25 21:34:13 -05:00
parent 2b7faeb920
commit da546bebb8
2 changed files with 16 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/UnitTests/Common/MathUtilTest.cpp
View File

@ -66,6 +66,13 @@ TEST(MathUtil, SaturatingCast)
// 16777217 = 2^24 + 1 is the first integer that cannot be represented correctly with a f32.
EXPECT_EQ(16777216, MathUtil::SaturatingCast<s32>(float(16777216)));
EXPECT_EQ(16777216, MathUtil::SaturatingCast<s32>(float(16777217)));
// Note that values in the range [2147483584, 2147483776] have an equivalent float representation.
EXPECT_EQ(std::numeric_limits<s32>::max(), MathUtil::SaturatingCast<s32>(2147483648.f));
EXPECT_EQ(std::numeric_limits<s32>::min(), MathUtil::SaturatingCast<s32>(-2147483649.f));
// Cast from a signed integer type to a smaller signed integer type
EXPECT_EQ(-128, (MathUtil::SaturatingCast<s8, int>(-129)));
}
TEST(MathUtil, RectangleEquality)