piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 23:29:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13319 from hoogmin/infinite-style-fix

Browse Source 
Refactor: Infinite loop in AsyncShaderCompiler according to style guidelines
This commit is contained in:
JosJuice
2025-02-06 18:31:28 +01:00
committed by GitHub
parent 6ee08fb9db 7dec083af5
commit db285b7c87
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Source/Core/VideoCommon/AsyncShaderCompiler.cpp
View File

@ -95,23 +95,20 @@ bool AsyncShaderCompiler::WaitUntilCompletion(
} }
// Update progress while the compiles complete. // Update progress while the compiles complete.
for (;;) while (Core::GetState(Core::System::GetInstance()) != Core::State::Stopping)
{ {
if (Core::GetState(Core::System::GetInstance()) == Core::State::Stopping)
return false;
size_t remaining_items; size_t remaining_items;
{ {
std::lock_guard<std::mutex> pending_guard(m_pending_work_lock); std::lock_guard<std::mutex> pending_guard(m_pending_work_lock);
if (m_pending_work.empty() && !m_busy_workers.load()) if (m_pending_work.empty() && !m_busy_workers.load())
break; return true;
remaining_items = m_pending_work.size(); remaining_items = m_pending_work.size();
} }
progress_callback(total_items - remaining_items, total_items); progress_callback(total_items - remaining_items, total_items);
std::this_thread::sleep_for(CHECK_INTERVAL); std::this_thread::sleep_for(CHECK_INTERVAL);
} }
return true; return false;
} }
bool AsyncShaderCompiler::StartWorkerThreads(u32 num_worker_threads) bool AsyncShaderCompiler::StartWorkerThreads(u32 num_worker_threads)