Merge pull request #6576 from lioncash/iconv

CMakeLists: Remove iconv from the LIBS variable
This commit is contained in:
Markus Wick
2018-04-02 11:07:19 +02:00
committed by GitHub
2 changed files with 5 additions and 3 deletions

View File

@ -706,7 +706,6 @@ else()
add_subdirectory(Externals/libiconv-1.14) add_subdirectory(Externals/libiconv-1.14)
set(ICONV_LIBRARIES iconv) set(ICONV_LIBRARIES iconv)
endif() endif()
list(APPEND LIBS ${ICONV_LIBRARIES})
if(NOT ANDROID) if(NOT ANDROID)
find_package(HIDAPI) find_package(HIDAPI)

View File

@ -44,12 +44,16 @@ add_library(common
x64Emitter.cpp x64Emitter.cpp
) )
target_link_libraries(common PUBLIC target_link_libraries(common
PUBLIC
${CMAKE_THREAD_LIBS_INIT} ${CMAKE_THREAD_LIBS_INIT}
${CURL_LIBRARIES} ${CURL_LIBRARIES}
enet enet
${MBEDTLS_LIBRARIES} ${MBEDTLS_LIBRARIES}
${VTUNE_LIBRARIES} ${VTUNE_LIBRARIES}
PRIVATE
${ICONV_LIBRARIES}
) )
if (APPLE) if (APPLE)
@ -65,7 +69,6 @@ if(ANDROID)
target_sources(common PRIVATE target_sources(common PRIVATE
Logging/ConsoleListenerDroid.cpp Logging/ConsoleListenerDroid.cpp
) )
target_link_libraries(common PRIVATE iconv)
elseif(WIN32) elseif(WIN32)
target_sources(common PRIVATE target_sources(common PRIVATE
Logging/ConsoleListenerWin.cpp Logging/ConsoleListenerWin.cpp