Use emplace_* functions where in-place construction is preferable

This commit is contained in:
Lioncash
2015-02-04 10:36:42 -05:00
parent 012a4c18ff
commit e07679114b
12 changed files with 18 additions and 18 deletions

View File

@ -128,9 +128,7 @@ void FramebufferManagerBase::CopyToVirtualXFB(u32 xfbAddr, u32 fbWidth, u32 fbHe
if (m_virtualXFBList.size() < MAX_VIRTUAL_XFB)
{
// create a new Virtual XFB and place it at the front of the list
VirtualXFB v;
memset(&v, 0, sizeof v);
m_virtualXFBList.push_front(v);
m_virtualXFBList.emplace_front();
vxfb = m_virtualXFBList.begin();
}
else

View File

@ -57,14 +57,16 @@ public:
protected:
struct VirtualXFB
{
VirtualXFB() : xfbSource(nullptr) {}
VirtualXFB()
{
}
// Address and size in GameCube RAM
u32 xfbAddr;
u32 xfbWidth;
u32 xfbHeight;
u32 xfbAddr = 0;
u32 xfbWidth = 0;
u32 xfbHeight = 0;
XFBSourceBase *xfbSource;
XFBSourceBase* xfbSource = nullptr;
};
typedef std::list<VirtualXFB> VirtualXFBListType;

View File

@ -129,7 +129,7 @@ void PostProcessingShaderConfiguration::LoadOptions(const std::string& code)
IniFile::ParseLine(line, &key, &value);
if (!(key == "" && value == ""))
current_strings->m_options.push_back(std::make_pair(key, value));
current_strings->m_options.emplace_back(key, value);
}
}
}