Add an option to abort when a panic alert occurs

Prompted by https://dolphin.ci/#/builders/24/builds/985

A 1-character typo in a recent PR caused FifoCI builds to break
horribly and spew millions of panic alerts until buildbot crashed.

This PR adds a new config option -- defaulting to off -- that allows
Dolphin to abort early on when a panic alert occurs instead of
continuing forever.
This commit is contained in:
Léo Lam
2021-08-29 01:53:12 +02:00
parent 4816195366
commit e091c2e817
6 changed files with 18 additions and 3 deletions

View File

@ -4,6 +4,7 @@
#include "Common/MsgHandler.h"
#include <cstdarg>
#include <cstdlib>
#include <string>
#ifdef _WIN32
@ -51,6 +52,7 @@ std::string DefaultStringTranslator(const char* text)
MsgAlertHandler s_msg_handler = DefaultMsgHandler;
StringTranslator s_str_translator = DefaultStringTranslator;
bool s_alert_enabled = true;
bool s_abort_on_panic_alert = false;
const char* GetCaption(MsgType style)
{
@ -94,6 +96,11 @@ void SetEnableAlert(bool enable)
s_alert_enabled = enable;
}
void SetAbortOnPanicAlert(bool should_abort)
{
s_abort_on_panic_alert = should_abort;
}
std::string GetStringT(const char* string)
{
return s_str_translator(string);
@ -114,6 +121,12 @@ bool MsgAlert(bool yes_no, MsgType style, const char* format, ...)
ERROR_LOG_FMT(MASTER_LOG, "{}: {}", caption, buffer);
// Panic alerts.
if (style == MsgType::Warning && s_abort_on_panic_alert)
{
std::abort();
}
// Don't ignore questions, especially AskYesNo, PanicYesNo could be ignored
if (s_msg_handler != nullptr &&
(s_alert_enabled || style == MsgType::Question || style == MsgType::Critical))