From e6b9091ffce7f87e241aef8818e7cd0ee4053782 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Mon, 8 Jul 2024 18:15:23 +0200 Subject: [PATCH] RetroAchievements: Skip LoadApprovedList if there are no patches There being no active patches is by far the most common case, so let's optimize for this case. --- Source/Core/Core/AchievementManager.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index d4ee8a0add..7a1837abbc 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -361,6 +361,12 @@ bool AchievementManager::IsHardcoreModeActive() const void AchievementManager::FilterApprovedPatches(std::vector& patches, const std::string& game_ini_id) const { + if (patches.empty()) + { + // There's nothing to verify, so let's save ourselves some work + return; + } + std::lock_guard lg{m_lock}; if (!IsHardcoreModeActive())