From e82c9e616d71448dac6b2e1368c42398fdc0ae19 Mon Sep 17 00:00:00 2001 From: comex Date: Sun, 22 Sep 2013 20:38:03 -0400 Subject: [PATCH] operator= is a function too! std::forward is still appropriate. Fix the potentially unsafe use of std::move I added to FifoQueue. --- Source/Core/Common/Src/FifoQueue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Common/Src/FifoQueue.h b/Source/Core/Common/Src/FifoQueue.h index f5713c85f9..60e23bf0ee 100644 --- a/Source/Core/Common/Src/FifoQueue.h +++ b/Source/Core/Common/Src/FifoQueue.h @@ -46,7 +46,7 @@ public: void Push(Arg&& t) { // create the element, add it to the queue - m_write_ptr->current = std::move(t); + m_write_ptr->current = std::forward(t); // set the next pointer to a new element ptr // then advance the write pointer ElementPtr* new_ptr = new ElementPtr();