piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

DiscIO: Fix NAND Memory Leak

Browse Source 
CNANDContentData is a base class with a non-virtual destructor so
derived classes don't get destroyed causing them to leak resources.
This commit is contained in:
EmptyChaos 2016-09-10 04:38:04 +00:00
parent 54a643a4a3
commit eccec3c6d3
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/DiscIO/NANDContentLoader.cpp
View File

@ -29,6 +29,8 @@
namespace DiscIO namespace DiscIO
{ {
CNANDContentData::~CNANDContentData() = default;
CSharedContent::CSharedContent() CSharedContent::CSharedContent()
{ {
UpdateLocation(); UpdateLocation();

1
Source/Core/DiscIO/NANDContentLoader.h
View File

@ -25,6 +25,7 @@ bool AddTicket(u64 title_id, const std::vector<u8>& ticket);
class CNANDContentData class CNANDContentData
{ {
public: public:
virtual ~CNANDContentData() = 0;
virtual void Open(){}; virtual void Open(){};
virtual const std::vector<u8> Get() = 0; virtual const std::vector<u8> Get() = 0;
virtual bool GetRange(u32 start, u32 size, u8* buffer) = 0; virtual bool GetRange(u32 start, u32 size, u8* buffer) = 0;