piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 07:09:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

NetPlayClient: Make the NetSettings instance part of the NetPlayClient class

Browse Source 
This is only ever read from externally, so we can expose a getter that ensures that
immutability, while making the actual instance internal. Given the
filling out of these settings depends on packets received by the client
instance, it makes more sense to make it a part of the client itself.

This trims off one lingering global.
This commit is contained in:
Lioncash
2018-07-09 15:52:31 -04:00
parent 68731995b5
commit f209f5f2a4
4 changed files with 36 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/Core/NetPlayProto.h
View File

@ -49,7 +49,6 @@ struct NetTraversalConfig
u16 traversal_port = 0;
};
extern NetSettings g_NetPlaySettings;
extern u64 g_netplay_initial_rtc;
struct Rpt : public std::vector<u8>
@ -112,4 +111,8 @@ using PadMapping = s8;
using PadMappingArray = std::array<PadMapping, 4>;
bool IsNetPlayRunning();
// Precondition: A netplay client instance must be present. In other words,
// IsNetPlayRunning() must be true before calling this.
const NetSettings& GetNetSettings();
} // namespace NetPlay