piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 14:49:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

Make overriding explicit and remove redundant virtual specifiers on overriding destructors - Core & UnitTests

Browse Source
This commit is contained in:
Dr. Dystopia
2025-04-16 09:17:46 +02:00
parent 0b0151770a
commit f240e20e3f
130 changed files with 195 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/VideoBackends/OGL/OGLGfx.h
View File

@ -17,7 +17,7 @@ class OGLGfx final : public AbstractGfx
{
public:
OGLGfx(std::unique_ptr<GLContext> main_gl_context, float backbuffer_scale);
~OGLGfx();
~OGLGfx() override;
bool IsHeadless() const override;
@ -67,9 +67,9 @@ public:
void WaitForGPUIdle() override;
void OnConfigChanged(u32 bits) override;
virtual void SelectLeftBuffer() override;
virtual void SelectRightBuffer() override;
virtual void SelectMainBuffer() override;
void SelectLeftBuffer() override;
void SelectRightBuffer() override;
void SelectMainBuffer() override;
std::unique_ptr<VideoCommon::AsyncShaderCompiler> CreateAsyncShaderCompiler() override;

6
Source/Core/VideoBackends/OGL/OGLPerfQuery.h
View File

@ -18,7 +18,7 @@ class PerfQuery : public PerfQueryBase
{
public:
PerfQuery();
~PerfQuery() {}
~PerfQuery() override {}
void EnableQuery(PerfQueryGroup group) override;
void DisableQuery(PerfQueryGroup group) override;
void ResetQuery() override;
@ -50,7 +50,7 @@ class PerfQueryGL : public PerfQuery
{
public:
PerfQueryGL(GLenum query_type);
~PerfQueryGL();
~PerfQueryGL() override;
void EnableQuery(PerfQueryGroup group) override;
void DisableQuery(PerfQueryGroup group) override;
@ -68,7 +68,7 @@ class PerfQueryGLESNV : public PerfQuery
{
public:
PerfQueryGLESNV();
~PerfQueryGLESNV();
~PerfQueryGLESNV() override;
void EnableQuery(PerfQueryGroup group) override;
void DisableQuery(PerfQueryGroup group) override;

12
Source/Core/VideoBackends/OGL/OGLStreamBuffer.cpp
View File

@ -142,7 +142,7 @@ public:
glBufferData(m_buffertype, m_size, nullptr, GL_STREAM_DRAW);
}
~MapAndOrphan() {}
~MapAndOrphan() override {}
std::pair<u8*, u32> Map(u32 size) override
{
if (m_iterator + size >= m_size)
@ -181,7 +181,7 @@ public:
glBufferData(m_buffertype, m_size, nullptr, GL_STREAM_DRAW);
}
~MapAndSync() { DeleteFences(); }
~MapAndSync() override { DeleteFences(); }
std::pair<u8*, u32> Map(u32 size) override
{
AllocMemory(size);
@ -234,7 +234,7 @@ public:
(coherent ? GL_MAP_COHERENT_BIT : GL_MAP_FLUSH_EXPLICIT_BIT));
}
~BufferStorage()
~BufferStorage() override
{
DeleteFences();
glUnmapBuffer(m_buffertype);
@ -280,7 +280,7 @@ public:
glBindBuffer(m_buffertype, m_buffer);
}
~PinnedMemory()
~PinnedMemory() override
{
DeleteFences();
glBindBuffer(m_buffertype, 0);
@ -315,7 +315,7 @@ public:
m_pointer = new u8[m_size];
}
~BufferSubData() { delete[] m_pointer; }
~BufferSubData() override { delete[] m_pointer; }
std::pair<u8*, u32> Map(u32 size) override { return std::make_pair(m_pointer, 0); }
void Unmap(u32 used_size) override { glBufferSubData(m_buffertype, 0, used_size, m_pointer); }
u8* m_pointer;
@ -335,7 +335,7 @@ public:
m_pointer = new u8[m_size];
}
~BufferData() { delete[] m_pointer; }
~BufferData() override { delete[] m_pointer; }
std::pair<u8*, u32> Map(u32 size) override { return std::make_pair(m_pointer, 0); }
void Unmap(u32 used_size) override
{

4
Source/Core/VideoBackends/OGL/OGLTexture.h
View File

@ -20,7 +20,7 @@ class OGLTexture final : public AbstractTexture
{
public:
explicit OGLTexture(const TextureConfig& tex_config, std::string_view name);
~OGLTexture();
~OGLTexture() override;
void CopyRectangleFromTexture(const AbstractTexture* src,
const MathUtil::Rectangle<int>& src_rect, u32 src_layer,
@ -71,7 +71,7 @@ class OGLStagingTexture final : public AbstractStagingTexture
{
public:
OGLStagingTexture() = delete;
~OGLStagingTexture();
~OGLStagingTexture() override;
void CopyFromTexture(const AbstractTexture* src, const MathUtil::Rectangle<int>& src_rect,
u32 src_layer, u32 src_level,

2
Source/Core/VideoBackends/OGL/OGLVertexManager.h
View File

@ -18,7 +18,7 @@ class GLVertexFormat : public NativeVertexFormat
{
public:
GLVertexFormat(const PortableVertexDeclaration& vtx_decl);
~GLVertexFormat();
~GLVertexFormat() override;
GLuint VAO;
};