From f5408c3f52a53368f790decbae2d780d6c8f09c1 Mon Sep 17 00:00:00 2001 From: lioncash Date: Mon, 10 Feb 2014 09:26:29 -0500 Subject: [PATCH] Clarify an if statement in NetPlayClient.cpp. See: https://github.com/LaurentGomila/SFML/issues/26. This was simply an error in documentation. It actually returns an sf::Socket::Status enum value as a result. --- Source/Core/Core/NetPlayClient.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Core/Core/NetPlayClient.cpp b/Source/Core/Core/NetPlayClient.cpp index f473cbd22a..02b71e495b 100644 --- a/Source/Core/Core/NetPlayClient.cpp +++ b/Source/Core/Core/NetPlayClient.cpp @@ -67,8 +67,7 @@ NetPlayClient::NetPlayClient(const std::string& address, const u16 port, NetPlay is_connected = false; - // why is false successful? documentation says true is - if (0 == m_socket.Connect(port, address, 5)) + if (m_socket.Connect(port, address, 5) == sf::Socket::Done) { // send connect message sf::Packet spac; @@ -126,8 +125,9 @@ NetPlayClient::NetPlayClient(const std::string& address, const u16 port, NetPlay } } else + { PanicAlertT("Failed to Connect!"); - + } } // called from ---NETPLAY--- thread