piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 07:09:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

JitArm64: Fix ps_cmpXX

Browse Source 
Passing a width of 64 and registers encoded as double to
DUP resulted in an invalid instruction. The registers should
be encoded as quads in this situation.

Fixes https://bugs.dolphin-emu.org/issues/12575.
This commit is contained in:
JosJuice
2021-07-11 11:43:19 +02:00
parent f6ca70d094
commit f903853cf7
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
View File

@ -387,6 +387,7 @@ void JitArm64::FloatCompare(UGeckoInstruction inst, bool upper)
const RegType lower_type = singles ? RegType::LowerPairSingle : RegType::LowerPair; const RegType lower_type = singles ? RegType::LowerPairSingle : RegType::LowerPair;
const RegType upper_type = singles ? RegType::Single : RegType::Register; const RegType upper_type = singles ? RegType::Single : RegType::Register;
const auto reg_encoder = singles ? EncodeRegToSingle : EncodeRegToDouble; const auto reg_encoder = singles ? EncodeRegToSingle : EncodeRegToDouble;
const auto paired_reg_encoder = singles ? EncodeRegToDouble : EncodeRegToQuad;
const bool upper_a = upper && !js.op->fprIsDuplicated[a]; const bool upper_a = upper && !js.op->fprIsDuplicated[a];
const bool upper_b = upper && !js.op->fprIsDuplicated[b]; const bool upper_b = upper && !js.op->fprIsDuplicated[b];
@ -409,7 +410,7 @@ void JitArm64::FloatCompare(UGeckoInstruction inst, bool upper)
if (upper_a) if (upper_a)
{ {
V0Q = fpr.GetReg(); V0Q = fpr.GetReg();
m_float_emit.DUP(singles ? 32 : 64, reg_encoder(V0Q), VA, 1); m_float_emit.DUP(singles ? 32 : 64, paired_reg_encoder(V0Q), paired_reg_encoder(VA), 1);
VA = reg_encoder(V0Q); VA = reg_encoder(V0Q);
} }
if (upper_b) if (upper_b)
@ -421,7 +422,7 @@ void JitArm64::FloatCompare(UGeckoInstruction inst, bool upper)
else else
{ {
V1Q = fpr.GetReg(); V1Q = fpr.GetReg();
m_float_emit.DUP(singles ? 32 : 64, reg_encoder(V1Q), VB, 1); m_float_emit.DUP(singles ? 32 : 64, paired_reg_encoder(V1Q), paired_reg_encoder(VB), 1);
VB = reg_encoder(V1Q); VB = reg_encoder(V1Q);
} }
} }