Markus Wick
f02b2f0cad
Merge pull request #7031 from lioncash/naming
...
AudioInterface: Minor changes
2018-05-30 16:38:18 +02:00
Lioncash
038bb9b3e1
AudioInterface: Use member initializers where applicable for unions
...
Migrates more code to the initialization capabilities available since C++11
2018-05-30 09:49:28 -04:00
Lioncash
b59cda1435
AudioInterface: Amend variable naming
...
Normalizes variable names to conform to our coding conventions.
Previously we were signifying some variables as externally linked
globals, which wasn't the case.
2018-05-30 09:47:08 -04:00
Lioncash
81e11b2406
x64Emitter: Amend parameter ordering for WriteModRM()'s prototype
...
The definition of the function uses the ordering {mod, reg, rm}, which
is correct. Match the prototype to this, so that the parameter list
isn't misleading.
2018-05-30 09:30:24 -04:00
Léo Lam
bdfd331355
Merge pull request #7028 from lioncash/obsolete
...
GeneralPane: Replace usages of obsolete QString member function sprintf
2018-05-30 15:02:41 +02:00
Léo Lam
b7a268ceea
Merge pull request #7029 from lioncash/any
...
VolumeWii: Shorten padding checking code within CheckIntegrity()
2018-05-30 14:58:16 +02:00
Lioncash
f845818cfe
VolumeWii: Shorten padding checking code within CheckIntegrity()
...
We can just use std::any_of here to collapse the checking code down to a
single assignment as opposed to a loop. This also slightly improves on
the existing code, as this won't continue to iterate through the cluster
metadata if an entry that's non-zero is encountered.
2018-05-30 08:42:32 -04:00
Lioncash
bd585f7389
GeneralPane: Replace usages of obsolete QString member function sprintf
...
sprintf is listed as obsolete within the documentation for Qt 5. Instead,
it recommends using the asprintf member function, arg(), or QTextStream.
2018-05-30 06:50:59 -04:00
Léo Lam
4fb2d580d8
Merge pull request #7026 from lioncash/name
...
JitAsmCommon: Normalize member variable names within CommonAsmRoutinesBase
2018-05-30 12:02:08 +02:00
Lioncash
986d644a01
JitAsmCommon: Make CommonAsmRoutinesBase a struct
...
This is just used as a means of carting around routines. It's not meant
to directly have functionality embedded within it--this is the job of
the inheriting data structure--so we can just make this a basic struct.
Particularly given all the data members were public to begin with.
2018-05-30 05:22:41 -04:00
Lioncash
f5f4c10fd1
JitAsmCommon: Amend member variable names for CommonAsmRoutinesBase
2018-05-30 05:22:36 -04:00
Léo Lam
eb9969a1e2
Merge pull request #7025 from lioncash/integrity
...
VolumeWii: Use ReadSwapped for retrieving the partition data size in CheckIntegrity()
2018-05-30 10:55:13 +02:00
Léo Lam
c3de9d7b0e
Merge pull request #7020 from sepalani/ida-scripts
...
Tools: Dolphin symbol map IDA scripts added
2018-05-30 10:52:49 +02:00
Lioncash
efabfc0b54
VolumeWii: Use ReadSwapped for retrieving the partition data size in CheckIntegrity()
...
Also make this a little more robust by handling the failure case for
the read as well.
2018-05-30 04:34:57 -04:00
Léo Lam
24e0b4bf52
Merge pull request #7024 from lioncash/discio
...
VolumeGC/VolumeWii: Dehardcode sizes where applicable
2018-05-30 10:22:18 +02:00
Lioncash
7bef470136
VolumeGC/VolumeWii: Dehardcode sizes where applicable
...
We can just use the relevant array to derive these sizes instead of hardcoding
them directly.
2018-05-30 04:14:42 -04:00
Tilka
9bf5ad1f0e
Merge pull request #7021 from akien-mga/cmake-pugixml
...
CMake: Fix case in FindPugixml resulting in false negative
2018-05-30 09:02:44 +01:00
Markus Wick
4bebd52850
Merge pull request #7017 from lioncash/arm
...
Arm64Emitter: Use Common::BitCast where applicable
2018-05-30 09:50:59 +02:00
Markus Wick
f33828e7a5
Merge pull request #7022 from akien-mga/gcc6-nested-namespaces
...
CMake: Increase minimum GCC version to 6.0
2018-05-30 09:47:07 +02:00
Markus Wick
cb64398304
Merge pull request #7023 from lioncash/discio
...
Volume/VolumeGC/VolumeWii: Amend variable naming
2018-05-30 09:46:11 +02:00
Lioncash
66122f037e
Volume/VolumeGC/VolumeWii: Amend variable naming
...
Drops prefixed underscores and normalizes names to follow our coding
style.
2018-05-30 03:33:12 -04:00
Rémi Verschelde
d37ccc844e
CMake: Fix case in FindPugixml resulting in false negative
...
As mentioned in GH-6652.
2018-05-30 09:12:24 +02:00
Rémi Verschelde
c36695175f
CMake: Increase minimum GCC version to 6.0
...
Dolphin uses nested namespaces from the C++17 standard,
which are only supported in GCC 6.0 and later.
See comments in GH-6866 for details.
2018-05-30 09:02:14 +02:00
JosJuice
ae4aa0b25c
Merge pull request #7010 from leoetlino/can-of-worms
...
Don't switch to blank NAND in the middle of emulation
2018-05-30 08:00:15 +02:00
JosJuice
243f353688
Merge pull request #7016 from lioncash/mem
...
MemoryPatches: Minor changes
2018-05-30 07:45:34 +02:00
JosJuice
6cb81ca851
Merge pull request #7015 from lioncash/pcap
...
PcapFile: Namespace code under the Common namespace
2018-05-30 07:45:09 +02:00
JosJuice
2f561dafd9
Merge pull request #7014 from lioncash/const
...
DSPEmulator: Make the IsLLE() member function const-qualified
2018-05-30 07:40:44 +02:00
Sepalani
a83858cac0
Tools: Dolphin symbol map IDA scripts added
...
Old ReadDolphinMap script removed
2018-05-30 09:13:12 +04:00
Mat M
1825e231a3
Merge pull request #7013 from degasus/double2single
...
Jit64: Fix MORE_ACCURATE_DOUBLETOSINGLE.
2018-05-29 21:01:47 -04:00
Ryan Meredith
e9563f0a84
Make DolphinQT2 the default project in dolphin-emu.sln
2018-05-29 20:26:51 -04:00
Mat M
7f6ae322ea
Merge pull request #7018 from spycrab/qt_confirm_dialog
...
Qt/GeneralWidget: Add icon and title to the backend switch confirm di…
2018-05-29 19:27:07 -04:00
spycrab
c07b89792d
Qt/GeneralWidget: Add icon and title to the backend switch confirm dialog
2018-05-30 01:19:31 +02:00
spycrab
a729c375f3
Merge pull request #7011 from spycrab/qt_jit_instant
...
Qt/MenuBar: Fix JIT Menu options not being applied instantly
2018-05-30 00:53:20 +02:00
Lioncash
6fd7a79b93
Arm64Emitter: Use Common::BitCast where applicable
...
Gets rid of the need to set up memcpy boilerplate to reinterpret between
floating-point and integers.
While we're at it, also do a minor bit of tidying.
2018-05-29 18:19:01 -04:00
Lioncash
397b27e665
MemoryPatches: In-class initialize is_enabled state for MemoryPatch instances
...
Given this is what occurs in both constructors (as one just passes
through to another), we can just initialize the member directly.
While we're at it, amend the struct to follow the general ordering
convention of:
<new types>
<functions>
<variables>
2018-05-29 18:04:06 -04:00
Lioncash
4c33bb8dda
MemoryPatches: std::move std::vector in the constructor
...
We can avoid copying the vector contents in this instance.
2018-05-29 18:01:16 -04:00
Lioncash
97c5a840db
PcapFile: Namespace code under the Common namespace
...
Brings more common code under the Common namespace.
2018-05-29 17:56:15 -04:00
Lioncash
a7de492696
DSPEmulator: Make the IsLLE() member function const-qualified
...
This function only queries state and doesn't modify it, so this can be
made a const member function
2018-05-29 17:45:07 -04:00
degasus
bde65d8b42
Jit64: Fix MORE_ACCURATE_DOUBLETOSINGLE.
...
This is broken since 3d12849967
.
2018-05-29 23:25:30 +02:00
spycrab
2beb135bdf
Merge pull request #7012 from spycrab/qt_always_connected
...
Qt/Mapping: Include "Always connected" option
2018-05-29 21:12:48 +02:00
spycrab
a1f15050a1
Qt/Mapping: Include "Always connected" option
2018-05-29 19:34:35 +02:00
spycrab
d98affbf47
Qt/MenuBar: Fix JIT Menu options not being applied instantly
2018-05-29 16:40:05 +02:00
Léo Lam
a4ec3ddef1
Don't switch to blank NAND in the middle of emulation
...
Switching to blank NAND when emulation is running is an extremely bad
idea. It's akin to opening up a Wii and replacing the NAND chip while
you're playing a game on it.
Except we're not even replacing it with a NAND that has the same
contents. The blank NAND has nothing in it except the save file for
the current game, which is likely to result in the emulated software
getting inconsistent results and possibly even crashing depending on
how it caches title information.
An example of games that check the saves for other games is
Mario Kart Wii -- it checks the filesystem for Super Mario Galaxy saves
to decide whether to unlock characters. With this 'switch NAND
while emulation is active' misfeature, this will likely break.
And that's the main problem: it encourages sloppy emulation and no one
really knows how many things it can break.
Just don't let the user do horrible things like that during emulation.
If they want to use a blank NAND, they can do so by starting input
recording before launching a game. It's likely they will want to do
this if they plan to share their DTM anyway.
2018-05-29 15:41:11 +02:00
Léo Lam
60c38d7781
Merge pull request #7007 from spycrab/qt_gecko_sort
...
Qt/GeckoCodeWidget: Autosort list and fix accessing the wrong element
2018-05-29 14:48:32 +02:00
Léo Lam
00d91db2ec
Merge pull request #7008 from spycrab/ddos_sux
...
Fix "Download Codes" hitting DDOS protection
2018-05-29 14:42:24 +02:00
Léo Lam
86bbf540cf
Merge pull request #7009 from lioncash/dsp
...
DSPEmulator: Default destructor in the cpp file
2018-05-29 14:16:50 +02:00
Lioncash
c33228e466
DSPEmulator: Default destructor in the cpp file
...
This gets rid of a -Wweak-vtables warning
2018-05-29 07:54:39 -04:00
spycrab
c086f894b1
Core/GeckoCodeConfig: Circumvent DDOS protection
2018-05-29 03:56:28 +02:00
spycrab
44784cf363
Common/HttpRequest: Add option to set cookies
2018-05-29 03:56:28 +02:00
spycrab
a00250bfe6
Qt/GeckoCodeWidget: Autosort list and fix accessing the wrong element
2018-05-29 03:36:35 +02:00