piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-15 13:57:57 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
32,495 Commits 5 Branches 11 Tags 1.3 GiB
ba2d04b793
Commit Graph

36 Commits

Author SHA1 Message Date
JosJuice
297b790e4f DiscIO: Add out of bounds checks for blob reading 2020-01-14 18:59:31 +01:00
Techjar
ff972e3673 Reformat repo to clang-format 7.0 rules 2019-05-06 18:48:04 +00:00
Filip Gawin
49fe9f5db1 Use empty instead of size 2019-02-13 00:03:49 +01:00
Lioncash
50a476c371 Assert: Uppercase assertion macros 
Macros should be all upper-cased. This is also kind of a wart that's
been sticking out for quite a while now (we avoid prefixing
underscores).
 2018-03-14 22:03:12 -04:00
JosJuice
f09ceaa735 Move IOFile to a separate file 
Reduces the number of files that need to be recompiled
when making changes to FileUtil.h.
 2017-06-15 21:33:50 +02:00
Lioncash
552c0d8404 Common: Move byte swapping utilities into their own header 
This moves all the byte swapping utilities into a header named Swap.h.

A dedicated header is much more preferable here due to the size of the
code itself. In general usage throughout the codebase, CommonFuncs.h was
generally only included for these functions anyway. These being in their
own header avoids dumping the lesser used utilities into scope. As well
as providing a localized area for more utilities related to byte
swapping in the future (should they be needed). This also makes it nicer
to identify which files depend on the byte swapping utilities in
particular.

Since this is a completely new header, moving the code uncovered a few
indirect includes, as well as making some other inclusions unnecessary.
 2017-03-03 17:18:18 -05:00
JosJuice
79f3b5c5ff Fix -Wshadow warning for file_entry 
This struct didn't follow our naming convention,
so let's rename the struct itself instead of
the variable that triggered the warning.
 2017-01-22 17:27:37 +01:00
JosJuice
b1873264d7 WbfsBlob: Don't wrap file_entry in std::unique_ptr 
There doesn't seem to be any reason for doing it.
 2017-01-11 13:39:46 +01:00
JosJuice
0363be4320 WbfsBlob: Remove m_total_files 
std::vector already keeps track of this for us.
 2017-01-11 13:39:38 +01:00
JosJuice
5c02795af0 WbfsBlob: Only open each file once 
The first file used to be opened once by
CreateBlobReader and once inside WbfsFileReader.
 2017-01-11 13:33:27 +01:00
JosJuice
d1ea00ed88 Only open file once when detecting blob type 2017-01-11 13:23:19 +01:00
Léo Lam
31ccfffd38 Common: Add alignment header 
Gets rid of duplicated alignment code.
 2016-12-06 20:33:53 +01:00
Pierre Bourdon
3570c7f03a Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
Lioncash
6295297ab3 DiscIO: Get rid of a few explicit deletes 2015-12-08 04:35:56 -05:00
Lioncash
edbbf493f8 DiscIO: Make factory methods return unique_ptrs 
Rather than rely on the developer to do the right thing,
just make the default behavior safely deallocate resources.

If shared semantics are ever needed in the future, the
constructor that takes a unique_ptr for shared_ptr can
be used.
 2015-12-07 05:57:37 -05:00
Tillmann Karras
1a8e2e16e3 DiscIO: implement WbfsBlob::GetDataSize() 2015-10-12 02:33:04 +02:00
Tillmann Karras
a92b4bda95 DiscIO: fix reading the last sector in WBFS 
Instead of rounding down, round up.
 2015-10-12 02:31:51 +02:00
Tillmann Karras
3a2efc9f4f DiscIO: merge initial WBFS reads 2015-10-12 02:31:51 +02:00
Tillmann Karras
f416106eec DiscIO: pre-swap WLBA 2015-10-12 02:31:51 +02:00
Tillmann Karras
b1100e4aa0 DiscIO: use std::min() in WBFS 2015-10-12 02:31:51 +02:00
Lioncash
cc036ca86c Common: Remove other Common prefixed headers from Common.h 2015-09-26 18:51:58 -04:00
JosJuice
9018b546c7 WbfsBlob: Don't enter an infinite loop when reading beyond end of disc 
read_size remained 0 when the "Read beyond end of disc" error occurs,
which made the while (nbytes) loop never end. As a fix, SeekToCluster
now explicitly sets available to 0 when the error occurs, and Read
checks for it.
 2015-07-06 15:41:37 +02:00
Tillmann Karras
30ebb2459e Set copyright year to when a file was created 2015-05-25 13:22:31 +02:00
Tillmann Karras
cefcb0ace9 Update license headers to GPLv2+ 2015-05-25 13:22:31 +02:00
Benjamin Przybocki
4f324ad742 Clean Up 2015-01-24 17:10:21 -06:00
JosJuice
467b3e6baf DiscIO: Clear error status when reading file 2014-12-14 13:16:21 +01:00
Rohit Nirmal
fbc64984ca Include CommonTypes.h instead of Common.h. 2014-09-08 15:39:58 -04:00
Lioncash
1977ea42ae DiscIO: Prefix class member variables with "m_" 2014-09-01 15:48:02 -04:00
Lioncash
a82675b7d5 Kill off some usages of c_str. 
Also changes some function params, but this is ok.
Some simplifications were also able to be made (ie. killing off strcmps with ==, etc).
 2014-03-14 13:51:23 -04:00
Matthew Parlane
31cfc73a09 Fixes spacing for "for", "while", "switch" and "if" 
Also moved && and || to ends of lines instead of start.
Fixed misc vertical alignments and some { needed newlining.
 2014-03-11 00:35:07 +13:00
Tillmann Karras
d802d39281 clang-modernize -use-nullptr 
and s/\bNULL\b/nullptr/g for *.cpp/h/mm files not compiled on my machine
 2014-03-09 21:14:26 +01:00
Tillmann Karras
6914eca167 Fix various warnings reported by clang 
- mostly remove unused variables
- rename some generic JIT identifiers
 2014-02-28 12:28:19 +01:00
Pierre Bourdon
c698c07755 Make DiscIO/ mostly IWYU clean (and fix errors in rest of the project detected by this change). 2014-02-22 23:37:29 +01:00
Lioncash
2afe215271 Convert all includes to relative paths. 2014-02-18 02:19:10 -05:00
Lioncash
6c4ee1753a Fix some vertical alignments 
ie. uses spaces for alignment.
 2014-02-16 20:12:05 -05:00
Jasper St. Pierre
34692ab826 Remove unnecessary Src/ folders 2013-12-31 14:03:19 -05:00