piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
42,481 Commits 5 Branches 11 Tags 1.3 GiB
f9f0806022
Commit Graph

32 Commits

Author SHA1 Message Date
Pokechu22
c296c34e00 Common/MsgHandler: Use caller's file and line number in log messages 
This will assist with finding the source of a panic alert based on logs; before, Common\MsgHandler.cpp:113 (or similar) was always used.
 2022-01-09 12:44:14 -08:00
Pokechu22
558de04cfc Common/Assert: Actually use the ASSERT_MSG's log type parameter 
Since it was unused, nonexistent values were used in a few places.  I've replaced them.
 2022-01-09 12:44:14 -08:00
Pokechu22
bab3ff0157 Common/MsgHandler: Remove non-format variants of PanicAlert 
They're no longer used.
 2022-01-09 12:44:14 -08:00
Pokechu22
ec9db320d3 Fix AbortOnPanicAlert with PanicAlertFmt 
PR #10066 added functionality to call std::abort when a panic alert occurs; however, that PR only implemented it for MsgAlert and not MsgAlertFmtImpl, meaning that the functionality was not used with PanicAlertFmt (only PanicAlert, which is not used frequently).
 2021-10-02 17:24:09 -07:00
Léo Lam
e091c2e817
Add an option to abort when a panic alert occurs 
Prompted by https://dolphin.ci/#/builders/24/builds/985

A 1-character typo in a recent PR caused FifoCI builds to break
horribly and spew millions of panic alerts until buildbot crashed.

This PR adds a new config option -- defaulting to off -- that allows
Dolphin to abort early on when a panic alert occurs instead of
continuing forever.
 2021-08-29 02:02:07 +02:00
Pierre Bourdon
e149ad4f0a
treewide: convert GPLv2+ license info to SPDX tags 
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
 2021-07-05 04:35:56 +02:00
xvrc
0ad13db633 MsgHandler: Correct question and warning captions 2021-06-12 17:42:27 -04:00
Lioncash
7b21f7af2e Common/MsgHandler: Add fmt-capable variants of the alert macros 
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
 2020-11-09 08:48:17 -05:00
Lioncash
4e8df93f41 Common: Migrate logging to fmt 
Continues the migration of our code over to the fmt logger.
 2020-10-23 14:58:03 -04:00
Silent
e792a67dc6
Improve thread safety and remove an unnecessary string allocation from MsgAlert 
s_msg_handler still seems thread unsafe, not sure if it should be or not
 2019-07-20 21:03:45 +02:00
Lioncash
4f1f55093f Common/MsgHandler: Namespace code within the Common namespace 
Closes another gap in the Common library where code isn't being
namespaced under it.
 2019-06-19 16:03:55 -04:00
Lioncash
e7dd46a531 Common/MsgHandler: Brace if statement in MsgAlert 
The condition travels more than one line, so the body should be braced.
While we're at it, make the comparison against nullptr explicit.
 2019-06-19 16:03:33 -04:00
Lioncash
0eddf6dd8f Common/MsgHandler: Use std::string's empty for emptiness checking in MsgAlert 
Provides more straightforward code compared to negating a length check.
 2019-06-19 16:00:16 -04:00
Lioncash
1968643297 Common/MsgHandler: Amend file-scope variable names 
Makes them follow our coding style.
 2019-06-16 23:37:03 -04:00
Lioncash
76b675e9f0 Common/MsgHandler: Make default message handler and translator's internally linked 
Previously these functions were declared without the static specifier,
giving them external linkage, which isn't really ideal.

Instead, we can place these functions up by the relevant file-scope
variables and place them inside an anonymous namespace with said variables,
giving them internal linkage.
 2019-06-16 23:37:03 -04:00
Lioncash
027c17558f Common/MsgHandler: Use fmt::print on non-Windows OSes 
Provides the same behavior.
 2019-06-16 23:37:00 -04:00
spycrab
7cb310791b Cleanup: Remove some left over references to wxWidgets 2018-08-07 15:48:17 +02:00
Michael M
737651f298 MsgHandler: small cleanup 2017-08-03 13:29:59 -07:00
Michael Maltese
713ec5ffd5 Add includes for building on Windows without PCH 2017-01-23 01:37:41 -08:00
Pierre Bourdon
3570c7f03a Reformat all the things. Have fun with merge conflicts. 2016-06-24 10:43:46 +02:00
JosJuice
74ea765427 Mark more strings for translation 2015-11-20 11:33:47 +01:00
Scott Mansell
2d38a59044 NoGui: Return no to yes/no panic alerts. 
Also, print to stderr instead of stdio.
 2015-11-08 14:10:26 +13:00
Rohit Nirmal
3b75f45cf6 Fix building with PCH disabled. 2015-09-28 11:51:08 -05:00
Lioncash
cc036ca86c Common: Remove other Common prefixed headers from Common.h 2015-09-26 18:51:58 -04:00
Tillmann Karras
30ebb2459e Set copyright year to when a file was created 2015-05-25 13:22:31 +02:00
Tillmann Karras
cefcb0ace9 Update license headers to GPLv2+ 2015-05-25 13:22:31 +02:00
Stevoisiak
93b16a4a2d Formatting/Whitespace Cleanup 
Various fixes to formatting and whitespace
 2015-02-25 10:48:21 -05:00
Rohit Nirmal
fbc64984ca Include CommonTypes.h instead of Common.h. 2014-09-08 15:39:58 -04:00
Matthew Parlane
31cfc73a09 Fixes spacing for "for", "while", "switch" and "if" 
Also moved && and || to ends of lines instead of start.
Fixed misc vertical alignments and some { needed newlining.
 2014-03-11 00:35:07 +13:00
Pierre Bourdon
83b7bb64aa Make Common/ mostly IWYU clean (and fix errors in rest of the project detected by this change). 2014-02-22 23:37:29 +01:00
Lioncash
2afe215271 Convert all includes to relative paths. 2014-02-18 02:19:10 -05:00
Jasper St. Pierre
34692ab826 Remove unnecessary Src/ folders 2013-12-31 14:03:19 -05:00