mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2024-11-15 05:47:56 -07:00
244d083f0e
Previously, PowerPC.h had four macros in it like so: \#define rPS0(i) (*(double*)(&PowerPC::ppcState.ps[i][0])) \#define rPS1(i) (*(double*)(&PowerPC::ppcState.ps[i][1])) \#define riPS0(i) (*(u64*)(&PowerPC::ppcState.ps[i][0])) \#define riPS1(i) (*(u64*)(&PowerPC::ppcState.ps[i][1])) Casting between object representations like this is undefined behavior. Given this is used heavily with the interpreter (that is, the most accurate, but slowest CPU backend), we don't exactly want to allow undefined behavior to creep into it. Instead, this adds a helper struct for operating with the paired singles, and replaces the four macros with a single macro for accessing the paired-singles/floating-point registers. This way, it's left up to the caller to explicitly decide how it wants to interpret the data (and makes it more obvious where different interpretations of the same data are occurring at, as there'll be a call to one of the [x]AsDouble() functions). |
||
|---|---|---|
| .. | ||
| Android | ||
| Core | ||
| DSPSpy | ||
| DSPTool | ||
| PCH | ||
| UnitTests | ||
| VSProps | ||
| .clang-format | ||
| CMakeLists.txt | ||
| dolphin-emu.sln | ||