mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2024-11-15 22:09:19 -07:00
09f3f9b41a
The class NonCopyable is, like the name says, supposed to disallow
copying. But should it allow moving?
For a long time, NonCopyable used to not allow moving. (It declared
a deleted copy constructor and assigment operator without declaring
a move constructor and assignment operator, making the compiler
implicitly delete the move constructor and assignment operator.)
That's fine if the classes that inherit from NonCopyable don't need
to be movable or if writing the move constructor and assignment
operator by hand is fine, but that's not the case for all classes,
as I discovered when I was working on the DirectoryBlob PR.
Because of that, I decided to make NonCopyable movable in c7602cc,
allowing me to use NonCopyable in DirectoryBlob.h. That was however
an unfortunate decision, because some of the classes that inherit
from NonCopyable have incorrect behavior when moved by default-
generated move constructors and assignment operators, and do not
explicitly delete the move constructors and assignment operators,
relying on NonCopyable being non-movable.
So what can we do about this? There are four solutions that I can
think of:
1. Make NonCopyable non-movable and tell DirectoryBlob to suck it.
2. Keep allowing moving NonCopyable, and expect that classes that
don't support moving will delete the move constructor and
assignment operator manually. Not only is this inconsistent
(having classes disallow copying one way and disallow moving
another way), but deleting the move constructor and assignment
operator manually is too easy to forget compared to how tricky
the resulting problems are.
3. Have one "MovableNonCopyable" and one "NonMovableNonCopyable".
It works, but it feels rather silly...
4. Don't have a NonCopyable class at all. Considering that deleting
the copy constructor and assignment operator only takes two lines
of code, I don't see much of a reason to keep NonCopyable. I
suppose that there was more of a point in having NonCopyable back
in the pre-C++11 days, when it wasn't possible to use "= delete".
I decided to go with the fourth one (like the commit title says).
The implementation of the commit is fairly straight-forward, though
I would like to point out that I skipped adding "= delete" lines
for classes whose only reason for being uncopyable is that they
contain uncopyable classes like File::IOFile and std::unique_ptr,
because the compiler makes such classes uncopyable automatically.
41 lines
1.1 KiB
C++
41 lines
1.1 KiB
C++
// Copyright 2014 Dolphin Emulator Project
|
|
// Licensed under GPLv2+
|
|
// Refer to the license.txt file included.
|
|
|
|
// PCAP is a standard file format for network capture files. This also extends
|
|
// to any capture of packetized intercommunication data. This file provides a
|
|
// class called PCAP which is a very light wrapper around the file format,
|
|
// allowing only creating a new PCAP capture file and appending packets to it.
|
|
//
|
|
// Example use:
|
|
// PCAP pcap(new IOFile("test.pcap", "wb"));
|
|
// pcap.AddPacket(pkt); // pkt is automatically casted to u8*
|
|
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
#include <memory>
|
|
|
|
#include "Common/CommonTypes.h"
|
|
#include "Common/File.h"
|
|
|
|
class PCAP final
|
|
{
|
|
public:
|
|
// Takes ownership of the file object. Assumes the file object is already
|
|
// opened in write mode.
|
|
explicit PCAP(File::IOFile* fp) : m_fp(fp) { AddHeader(); }
|
|
template <typename T>
|
|
void AddPacket(const T& obj)
|
|
{
|
|
AddPacket(reinterpret_cast<const u8*>(&obj), sizeof(obj));
|
|
}
|
|
|
|
void AddPacket(const u8* bytes, size_t size);
|
|
|
|
private:
|
|
void AddHeader();
|
|
|
|
std::unique_ptr<File::IOFile> m_fp;
|
|
};
|