dolphin/Source/Core/DolphinQt/FIFO
JosJuice 72cf2bdb87 Audit uses of IsRunning and GetState
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.
2024-06-21 20:52:55 +02:00
..
FIFOAnalyzer.cpp Replace Common::BitCast with std::bit_cast 2024-05-03 18:43:51 -07:00
FIFOAnalyzer.h DolphinQt Settings: Signal Debug Font By Const Reference 2024-03-22 07:52:52 -07:00
FIFOPlayerWindow.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
FIFOPlayerWindow.h FifoRecorder: Move instance to System. 2024-01-12 15:06:06 +01:00